From 24b7552eb51cbe14eef00d269e76ae335c8f368e Mon Sep 17 00:00:00 2001 From: Lucas Date: Thu, 16 Jan 2025 17:00:06 +0100 Subject: [PATCH] chore(argo-apps): Remove deprecated argocd-notifications component --- charts/argo-apps/Chart.yaml | 33 +++---------------- charts/argo-apps/README.md | 3 +- .../templates/argocd-notifications.yaml | 3 -- charts/argo-apps/values.yaml | 13 -------- 4 files changed, 6 insertions(+), 46 deletions(-) delete mode 100644 charts/argo-apps/templates/argocd-notifications.yaml diff --git a/charts/argo-apps/Chart.yaml b/charts/argo-apps/Chart.yaml index 0689b9baf..c2ddf9aaf 100644 --- a/charts/argo-apps/Chart.yaml +++ b/charts/argo-apps/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: argo-apps description: Argo CD app-of-apps config for various argo project components type: application -version: 0.25.0 +version: 0.26.0 home: https://github.com/adfinis/helm-charts/tree/main/charts/argo-apps sources: - https://github.com/adfinis/helm-charts @@ -17,30 +17,7 @@ dependencies: annotations: artifacthub.io/changes: | - kind: changed - description: "feat(argo-rollouts): update from 1.7.0 to 1.7.2" - links: - - name: GitHub Release 1.7.1 - url: https://github.com/argoproj/argo-rollouts/releases/tag/v1.7.1 - - name: GitHub Release 1.7.2 - url: https://github.com/argoproj/argo-rollouts/releases/tag/v1.7.2 - - kind: changed - description: "feat(argo-rollouts): update chart from 2.36.0 to 2.38.0" - links: - - name: "fix: Change type of trafficRouterPlugins and trafficRouterPlugins as list" - url: https://github.com/argoproj/argo-helm/pull/3036 - - name: "fix: plugin block rendering" - url: https://github.com/argoproj/argo-helm/pull/3014 - - name: "feat: Add loadBalancerClass field for Service resources" - url: https://github.com/argoproj/argo-helm/pull/2772 - - name: "fix: Align permissions for controller's ClusterRole / Role" - url: https://github.com/argoproj/argo-helm/pull/2830 - - name: "feat: add option to disable creation of notifications configmap" - url: https://github.com/argoproj/argo-helm/pull/2849 - - name: "fix: Add traefik apiGroup" - url: https://github.com/argoproj/argo-helm/pull/2703 - - name: "fix: fix global subscriptions for Rollouts" - url: https://github.com/argoproj/argo-helm/pull/2797 - - name: "fix: add subscriptions in notifications configmap" - url: https://github.com/argoproj/argo-helm/pull/2793 - - name: "fix: add annotations for notificactions secret" - url: https://github.com/argoproj/argo-helm/pull/2777 + description: | + Remove deprecated Argo CD Notifications App. + + The functionality has been merged into the main Argo CD application. diff --git a/charts/argo-apps/README.md b/charts/argo-apps/README.md index c28e9886a..73c11f370 100644 --- a/charts/argo-apps/README.md +++ b/charts/argo-apps/README.md @@ -1,6 +1,6 @@ # argo-apps -![Version: 0.25.0](https://img.shields.io/badge/Version-0.25.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) +![Version: 0.26.0](https://img.shields.io/badge/Version-0.26.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) Argo CD app-of-apps config for various argo project components @@ -31,7 +31,6 @@ This chart is maintained by [Adfinis](https://adfinis.com/?pk_campaign=github&pk | argoRollouts.repoURL | string | [repo](https://argoproj.github.io/argo-helm) | Repo URL | | argoRollouts.targetRevision | string | `"2.38.0"` | [argo-rollouts Helm chart](https://github.com/argoproj/argo-helm/tree/main/charts/argo-rollouts) version | | argoRollouts.values | object | [upstream values](https://github.com/argoproj/argo-helm/blob/main/charts/argo-rollouts/values.yaml) | Helm values | -| argocdNotifications | object | DEPRECATED | [Argo CD Notifications](https://argocd-notifications.readthedocs.io/en/stable/) is DEPRECATED, use Argo CD directly instead. | | argoconfig.application.annotations | object | `{}` | Optional annotations to add to all Applications metadata. | ## About this chart diff --git a/charts/argo-apps/templates/argocd-notifications.yaml b/charts/argo-apps/templates/argocd-notifications.yaml deleted file mode 100644 index a72d8e6a7..000000000 --- a/charts/argo-apps/templates/argocd-notifications.yaml +++ /dev/null @@ -1,3 +0,0 @@ -{{ if .Values.argocdNotifications.enabled }} -{{ fail "Argo CD Notifications is DEPRECATED, use Argo CD directly instead" }} -{{ end }} diff --git a/charts/argo-apps/values.yaml b/charts/argo-apps/values.yaml index d8c6ba7da..cf48404f2 100644 --- a/charts/argo-apps/values.yaml +++ b/charts/argo-apps/values.yaml @@ -3,19 +3,6 @@ argoconfig: # -- Optional annotations to add to all Applications metadata. annotations: {} -# -- [Argo CD Notifications](https://argocd-notifications.readthedocs.io/en/stable/) is DEPRECATED, use Argo CD directly instead. -# @default -- DEPRECATED -argocdNotifications: - enabled: false - name: argocd-notifications - annotations: {} - destination: - namespace: "infra-argocd" - repoURL: "https://argoproj.github.io/argo-helm" - chart: "argocd-notifications" - targetRevision: "1.8.*" - values: {} - # -- [Argo Rollouts](https://argoproj.github.io/argo-rollouts/) ([example](./examples/argo-rollouts.yaml)) # @default -- - argoRollouts: