Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize solution matrix type #19

Open
adknudson opened this issue Apr 7, 2024 · 0 comments
Open

Standardize solution matrix type #19

adknudson opened this issue Apr 7, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@adknudson
Copy link
Owner

AlternatingProjections returns a Matrix while others return a Symmetric.

G = rand(4, 4)
nearest_cor(G, Newton()) # returns LinearAlgebra.Symmetric{Float64}
nearest_cor(G, AlternatingProjections()) # returns Matrix{Float64}

The output matrix type should be consistent for all algorithms. This can be fixed by wrapping the solution in Symmetric in the build_ncm_solution method.

@adknudson adknudson self-assigned this Apr 7, 2024
@adknudson adknudson added the bug Something isn't working label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant