Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect requires version in version.php #49

Open
danmarsden opened this issue Dec 17, 2024 · 0 comments
Open

Incorrect requires version in version.php #49

danmarsden opened this issue Dec 17, 2024 · 0 comments

Comments

@danmarsden
Copy link

your version states it supports 3.0 and higher.
https://github.com/adlnet/Moodle-mod_cmi5launch/blob/main/version.php#L34

But... PHP lint is failing on PHP 7.4 which means your plugin really only supports Moodle 4.3 and higher - to support Moodle 4.2 and lower you need to support PHP 7.4.

Easiest thing to do would be to fix the requires version in your version.php unless you want to make your code support php 7.4?

This is probably a blocker for plugins db approval because people wlll try to install your plugin in older Moodle versions which it doesn't actually support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant