-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short Period High Eccentricity After MCMC #138
Comments
👋 Could you share a plot of the radial velocity data vs. time? If that's proprietary, you can email me instead of posting here! |
Hm ok, nothing looks immediately strange about the RV data! One quick question: are the RV uncertainties very small? What are the typical values? Have you checked the convergence statistics for the MCMC run? Does it look like that ran successfully? For example, if you print |
Hi sorry for the delay! I was able to create a MWE for this issue and attached it to this comment along with the output files when running it with 50 million samples and 8 chains. Please let me know if you need anything else. Thank you! https://github.com/ella918/Summer-Research/blob/main/MWE_1.py Period vs Eccentricity after rejection sampling |
Hi I'm a student working with @stephtdouglas measuring periods for binaries. For stars of short periods, the original rejection sampling (without MCMC) is resulting in short eccentricities which is what we are expecting. However, when MCMC is done on stars with 1 rejection sample and with short periods, the orbits are being pushed towards higher eccentricities. This is occurring on 7 stars in our sample.
Below is an example of this, a star with a Gaia ID of 2128124963389008384.
This is the period vs eccentricity plot after rejection sampling
This is the period vs eccentricity after MCMC
Here is the script I am using
https://github.com/ella918/Summer-Research/blob/main/RunTheJokerOnePrior.py
The text was updated successfully, but these errors were encountered: