From 33eae1e03ac5c0f0033d0b1614e11f39f6a34ea2 Mon Sep 17 00:00:00 2001
From: advplyr <advplyr@protonmail.com>
Date: Fri, 11 Oct 2024 16:55:09 -0500
Subject: [PATCH] Fix:Server crash on podcast add page, adds API endpoint to
 get podcast titles #3499 - Instead of loading all podcast library items this
 page now loads only the needed data

---
 .../widgets/AlreadyInLibraryIndicator.vue     |  7 +---
 .../pages/library/_library/podcast/search.vue | 12 +++---
 server/controllers/LibraryController.js       | 38 +++++++++++++++++++
 server/routers/ApiRouter.js                   |  1 +
 4 files changed, 47 insertions(+), 11 deletions(-)

diff --git a/client/components/widgets/AlreadyInLibraryIndicator.vue b/client/components/widgets/AlreadyInLibraryIndicator.vue
index 14f2143d40..cb6bfb30cf 100644
--- a/client/components/widgets/AlreadyInLibraryIndicator.vue
+++ b/client/components/widgets/AlreadyInLibraryIndicator.vue
@@ -1,14 +1,11 @@
 <template>
-  <ui-tooltip v-if="alreadyInLibrary" :text="$strings.LabelAlreadyInYourLibrary" direction="top">
-    <span class="material-symbols ml-1 text-success" style="font-size: 0.8rem">check_circle</span>
+  <ui-tooltip :text="$strings.LabelAlreadyInYourLibrary" direction="top" class="inline-flex">
+    <span class="material-symbols ml-1 text-sm text-success">check_circle</span>
   </ui-tooltip>
 </template>
 
 <script>
 export default {
-  props: {
-    alreadyInLibrary: Boolean
-  },
   data() {
     return {}
   },
diff --git a/client/pages/library/_library/podcast/search.vue b/client/pages/library/_library/podcast/search.vue
index b80ca2f8f3..fd44df97d7 100644
--- a/client/pages/library/_library/podcast/search.vue
+++ b/client/pages/library/_library/podcast/search.vue
@@ -22,7 +22,7 @@
               <div class="flex items-center">
                 <a :href="podcast.pageUrl" class="text-base md:text-lg text-gray-200 hover:underline" target="_blank" @click.stop>{{ podcast.title }}</a>
                 <widgets-explicit-indicator v-if="podcast.explicit" />
-                <widgets-already-in-library-indicator :already-in-library="podcast.alreadyInLibrary" />
+                <widgets-already-in-library-indicator v-if="podcast.alreadyInLibrary" />
               </div>
               <p class="text-sm md:text-base text-gray-300 whitespace-nowrap truncate">{{ $getString('LabelByAuthor', [podcast.artistName]) }}</p>
               <p class="text-xs text-gray-400 leading-5">{{ podcast.genres.join(', ') }}</p>
@@ -211,15 +211,15 @@ export default {
     async fetchExistentPodcastsInYourLibrary() {
       this.processing = true
 
-      const podcasts = await this.$axios.$get(`/api/libraries/${this.currentLibraryId}/items?page=0&minified=1`).catch((error) => {
+      const podcastsResponse = await this.$axios.$get(`/api/libraries/${this.currentLibraryId}/podcast-titles`).catch((error) => {
         console.error('Failed to fetch podcasts', error)
         return []
       })
-      this.existentPodcasts = podcasts.results.map((p) => {
+      this.existentPodcasts = podcastsResponse.podcasts.map((p) => {
         return {
-          title: p.media.metadata.title.toLowerCase(),
-          itunesId: p.media.metadata.itunesId,
-          id: p.id
+          title: p.title.toLowerCase(),
+          itunesId: p.itunesId,
+          id: p.libraryItemId
         }
       })
       this.processing = false
diff --git a/server/controllers/LibraryController.js b/server/controllers/LibraryController.js
index a27255435e..5b7d0b3b1e 100644
--- a/server/controllers/LibraryController.js
+++ b/server/controllers/LibraryController.js
@@ -1226,6 +1226,44 @@ class LibraryController {
     })
   }
 
+  /**
+   * GET: /api/libraries/:id/podcast-titles
+   *
+   * Get podcast titles with itunesId and libraryItemId for library
+   * Used on the podcast add page in order to check if a podcast is already in the library and redirect to it
+   *
+   * @param {LibraryControllerRequest} req
+   * @param {Response} res
+   */
+  async getPodcastTitles(req, res) {
+    if (!req.user.isAdminOrUp) {
+      Logger.error(`[LibraryController] Non-admin user "${req.user.username}" attempted to get podcast titles`)
+      return res.sendStatus(403)
+    }
+
+    const podcasts = await Database.podcastModel.findAll({
+      attributes: ['id', 'title', 'itunesId'],
+      include: {
+        model: Database.libraryItemModel,
+        attributes: ['id', 'libraryId'],
+        where: {
+          libraryId: req.library.id
+        }
+      }
+    })
+
+    res.json({
+      podcasts: podcasts.map((p) => {
+        return {
+          title: p.title,
+          itunesId: p.itunesId,
+          libraryItemId: p.libraryItem.id,
+          libraryId: p.libraryItem.libraryId
+        }
+      })
+    })
+  }
+
   /**
    *
    * @param {RequestWithUser} req
diff --git a/server/routers/ApiRouter.js b/server/routers/ApiRouter.js
index 1e9d274516..57067ad8bb 100644
--- a/server/routers/ApiRouter.js
+++ b/server/routers/ApiRouter.js
@@ -96,6 +96,7 @@ class ApiRouter {
     this.router.get('/libraries/:id/opml', LibraryController.middleware.bind(this), LibraryController.getOPMLFile.bind(this))
     this.router.post('/libraries/order', LibraryController.reorder.bind(this))
     this.router.post('/libraries/:id/remove-metadata', LibraryController.middleware.bind(this), LibraryController.removeAllMetadataFiles.bind(this))
+    this.router.get('/libraries/:id/podcast-titles', LibraryController.middleware.bind(this), LibraryController.getPodcastTitles.bind(this))
 
     //
     // Item Routes