Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support podcast episode Pub Date without specifying time #1519

Open
apiweb opened this issue Feb 19, 2023 · 2 comments · Fixed by #3805
Open

[Enhancement] Support podcast episode Pub Date without specifying time #1519

apiweb opened this issue Feb 19, 2023 · 2 comments · Fixed by #3805
Labels
enhancement New feature or request

Comments

@apiweb
Copy link

apiweb commented Feb 19, 2023

Describe the issue

When I try to edit a podcast episode. If I don't input a time on the Pub Date field, the form is submitted with a null PubDate value.
Some episodes I don't hour the hour date, but the ABS required a time when I try to edit a podcast file.
If I input only the date info, my request is sent with a null/empty value as PubDate.

image

Steps to reproduce the issue

  1. Edit a podcast episode
  2. Click on the pub date and insert only the date
  3. Save the episode
  4. The pub date is saved as null

This happens if you are using the tab key to jump between the inputs
When you insert a date (typing, not choosing by the calendar component), if you press the tab key, the form will jump to the Title field, just with the Date inserted on the PubDate field.
And if you try to save just the date, a null value is sent instead of the Date only.

ErrorOnTheRequest

Audiobookshelf version

v2.2.15

How are you running audiobookshelf?

Docker

@apiweb apiweb added the bug Something isn't working label Feb 19, 2023
@advplyr advplyr changed the title [Bug]: Pub Date without Time is not [Enhancement] Support podcast episode Pub Date without specifying time Jul 15, 2023
@advplyr advplyr added enhancement New feature or request and removed bug Something isn't working labels Jul 15, 2023
@chrishoage
Copy link

chrishoage commented Jan 6, 2025

To me this is a data loss bug. The form should be in an "invalid" state and not let you save at the very least.

I just spent a lot of time filling out podcast details not knowing I was not saving my work.

Edit: My suggestion of disallowing the form submission when the date is invalid was completed in #3805

@advplyr
Copy link
Owner

advplyr commented Jan 7, 2025

The next release will include an error message preventing submission and a red border showing the date is invalid. It won't support leaving the time blank so I'll leave this open.

The issue with leaving the time blank is that we are using the browsers native datetime input by passing datetime-local in the type attribute of the HTML input. When the date and time is either incomplete or invalid the value is left empty on the input.

For example, if you type "25/01/2015" and leave the time blank there is no way (that I know of) to get the "25/01/2015". We have to build a custom input to support that.

I wrote a bit more about that here #3805 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants