Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: missing translation 2.13+ #3352

Closed
Machou opened this issue Aug 31, 2024 · 6 comments
Closed

[Enhancement]: missing translation 2.13+ #3352

Machou opened this issue Aug 31, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Machou
Copy link
Contributor

Machou commented Aug 31, 2024

Hello !

  1. In French, we have a problem with new tranlsations here:

In French, we can say

Modifié le {date}

Items problems:

  • Year of publication
  • Date added
  • Date of modification

Work with:

  • Size
  • Duration

1


  1. If the item is an eBook, Duration is useless ^^

2


  1. Upload a file: Updated & Added

3


  1. Upload a file, notification : Successfully uploaded 1 item

4

@Machou Machou added the enhancement New feature or request label Aug 31, 2024
@nichwall
Copy link
Contributor

For point 1, you can edit the translation of LabelFileModifiedDate to put the {0} wherever the date should show up in the string.

@Machou
Copy link
Contributor Author

Machou commented Sep 1, 2024

For point 1, you can edit the translation of LabelFileModifiedDate to put the {0} wherever the date should show up in the string.

Can i try my new tranlsation ?

I use docker to try find my fr.json but i ddin't find it.

Maybe I did something wrong, here's how I did it:

docker exec -it audiobookshelf /bin/sh
find / -iname "fr.json"

If I can test my translations before publishing a release, that would be even better!

@nichwall
Copy link
Contributor

nichwall commented Sep 1, 2024

I don't think you can edit the strings manually in the docker container, because the web client is built using those source files before the docker image is distributed. You can run from source with Node 20 installed on your system by cloning the project and then editing strings manually in client/strings/fr.json. The npm run generate command is what builds the web client (commands to build and run the server/client in the project readme).

https://github.com/advplyr/audiobookshelf?tab=readme-ov-file#manual-environment-setup

Edits to the language files should still be done through Weblate for the main project. If you can't run the server from source or in a development container, you can make changes on Weblate and then wait for the PR to be merged to see if everything looks correct in the edge docker image. This way is not great because you will have a long delay between when you make your edits and when the PR is merged to see your edits.

@Machou
Copy link
Contributor Author

Machou commented Sep 20, 2024

  1. Upload a file: Updated & Added

3

@Machou
Copy link
Contributor Author

Machou commented Sep 20, 2024

  1. Upload a file, notification : Successfully uploaded 1 item

4

advplyr added a commit that referenced this issue Sep 28, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Sep 28, 2024
Copy link

github-actions bot commented Oct 5, 2024

Fixed in v2.14.0.

@github-actions github-actions bot closed this as completed Oct 5, 2024
@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants