[Bug]: Creating new user incorrectly generates warning for tag access control

[nichwall]

What happened?

Created a new user with or without access control by tags. A warning is incorrectly logged, but access control is correctly applied.

Investigating in the code, looks like this is specifically due to line 162 because the selectedTagNotAccessible is an array and handled before the loop over the request keys. Note that this only applies for tags, access control by libraries does not generate this warning.

audiobookshelf/server/controllers/UserController.js

Lines 141 to 168 in 48f2327

	let reqItemTagsSelected = req.body.itemTagsSelected || req.body.permissions?.itemTagsSelected
	if (reqItemTagsSelected && (!Array.isArray(reqItemTagsSelected) || reqItemTagsSelected.some((tagId) => typeof tagId !== 'string'))) {
	Logger.warn(`[UserController] create: Invalid itemTagsSelected value: ${reqItemTagsSelected}`)
	reqItemTagsSelected = null
	}
	if (req.body.permissions?.itemTagsSelected || req.body.permissions?.librariesAccessible) {
	delete req.body.permissions.itemTagsSelected
	delete req.body.permissions.librariesAccessible
	}
	// Map permissions
	const permissions = Database.userModel.getDefaultPermissionsForUserType(userType)
	if (req.body.permissions && typeof req.body.permissions === 'object') {
	for (const key in req.body.permissions) {
	if (permissions[key] !== undefined) {
	if (typeof req.body.permissions[key] !== 'boolean') {
	Logger.warn(`[UserController] create: Invalid permission value for key ${key}. Should be boolean`)
	} else {
	permissions[key] = req.body.permissions[key]
	}
	} else {
	Logger.warn(`[UserController] create: Invalid permission key: ${key}`)
	}
	}
	}
	permissions.itemTagsSelected = reqItemTagsSelected || []
	permissions.librariesAccessible = reqLibrariesAccessible || []

What did you expect to happen?

No warning for creating/updating a user with tag access control.

Steps to reproduce the issue

1. Create new user and disable "User can access all tags"

Audiobookshelf version

v2.13.2

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Other (list in "Additional Notes" box)

If the issue is being seen in the UI, what browsers are you seeing the problem on?

None

Logs

[UserController] create: Invalid permission key: selectedTagsNotAccessible

Additional Notes

Synology NAS

[nichwall]

Update, the "tag invert" is not stored correctly. Related to #3365

[nichwall]

Well, I went on a wild goose chase because I misunderstood the error.
Duplicate of #3365