Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add published decade filter option #3489

Merged
merged 10 commits into from
Oct 8, 2024

Conversation

glorenzen
Copy link
Contributor

This adds a library filter option for Published Decade and resolves #3448

It doesn't follow the same format as the images in the issue, but I thought "Published Decade" was more descriptive and user-friendly than just "Published" in the top list with "Decade XXXX" in the sublist.

Everything seems to be working on my end, but there may be something I'm missing.

image

image

client/strings/en-us.json Outdated Show resolved Hide resolved
@advplyr
Copy link
Owner

advplyr commented Oct 8, 2024

Working great, nice and clean, thanks!

The projects formatting options are setup for vscode and should automatically remove semicolons on save. If you're not using vscode the .prettierrc and .editorconfig files might be able to work with your code editor to auto apply our formatting settings.

@advplyr advplyr merged commit f38b663 into advplyr:master Oct 8, 2024
6 checks passed
@glorenzen
Copy link
Contributor Author

I am using VS Code, so that's weird it didn't remove the semicolons automatically. I'll have to check that there isn't something that I misconfigured.

@pwinnski
Copy link

Thank you, @glorenzen! I totally agree that your solution is better than my proposal. I wasn't sure how "Published Decade" would look with all the other single-word items in that last, but I clearly chose poorly, as it looks great!

@pwinnski
Copy link

Minor nit, I have a single book for which the published year is 0400, and while 400 appears as an option in the Published Decade list, selecting that option tells me there are no matches, so apparently it doesn't like the three-digit year.
Still, this is great!

@glorenzen
Copy link
Contributor Author

@pwinnski I just opened a new pull request with a fix for the issue you're having: #3518

@glorenzen glorenzen deleted the decade-filter-option branch October 14, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: "Published > Decade" filter option
3 participants