-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
running dev-tools on a new fedora 17 minimal install results in error: #9
Comments
Hmm, I have seen this bug and we removed the command to add the puppet group as part of #8 . However, I tested it on f16, f17 and on rhel6 instances that did not have puppet groups and did not see the issue. I just retried on an f16 instance with no puppet group and it seemed to work. What do you get for "puppet --version"? |
Sure. It says: 3.0.1 It's a couple minute's job to retry including new Fedora minimal install, so feel free to request any assistance. |
@martinpovolny, the boostrap command will echo dueing execution and before launching puppet a message pointing you to a known bug from puppet. Is the error you're seeing the same described in the bug report? This is a link to the actual bug: http://projects.puppetlabs.com/issues/9862 |
hi, I did not notice such bug in the output I have just rerun the test and get to similar result I did: install minimal fedora 17 unfortunately when I tried to copy the output from the screen I screwed it up :-( I will come back to this issue in 2 days if you need more input, I am out of office atm might there be the problem in running as root? I can retry as a unprivileged user then... |
here is the full output, if a run the bootstrap on the same machine for a second time: [root@test4 martin]# curl https://raw.github.com/aeolus-incubator/dev-tools/master/bootstrap.sh | /bin/bash -x
|
hi Martin, thanks for helping with this. The lines which alert about the bugs are here: echo 'Given this puppet bug http://projects.puppetlabs.com/issues/9862' Given this puppet bug http://projects.puppetlabs.com/issues/9862 echo 'you may need to add manually the '''puppet''' group to the system in case of errors.' you may need to add manually the 'puppet' group to the system in case of errors. but I'm of the idea that, because you're not exporting RBENV_VERSION, the script is installing some rpms for you and using the system-wide ruby distribution, instead of rbenv. This is a 'supported' use case, but nothing I ever tested cause I was interested in using RBENV. I suspect you're facing such an issue because the version of puppet installed by YUM suffers the bug in question. |
@martinpovolny Yes, that you are running as root is the difference that is causing the problem. The script isn't intended to be run as root anymore since that will fire up a few processes (dbomatic, conductor, delayed jobs) as root. So, two possible options:
I kind of favor 1 because I like scripts that just work. Either way we should also take out giulivo's echo statement since it appears to be a root-only issue. |
@cwolferh the thing is that I don't like the idea of adding a system-wide 'puppet' group only to fix a particular bug. It only affects some versions of puppet and people using RBENV (or on recent distros) should never face such a problem cause the newer versions of puppet seem to have fixed it I think we should prevent the script from being launched as root, strip out the '-x' from the bash arguments, but don't see the need for any other change. I'd be happy to keep the sudo thing only to install the dependencies and make it use RBENV by default, even when RBENV_EXPORT is not set. |
@martinpovolny can you please help confirming if the following steps:
produce a working install? |
well the thing is that having clean nice code and/or environment etc. is important, but not as important as having the code working so if it's needed in some setups to add a system-wide puppet group, you should do it if you do not like the idea of adding it everywhere, then you should try to detect when it is needed just my 2 cents |
I did the above steps w/o the RBENV_ line and got a running conductor |
As a clarity thing, is this issue on F16 (as per issue title), F17, or both? |
sorry, it's F17, fixed the title |
This is a continuation of the "add puppet group" discussion from #8 (bootstrap.sh added the puppet group once upon a time). A similar issue with fc17 (or actually any OS with a version of facter after 1.6.13) is with facter, i.e., "Error: Could not run: Could not retrieve facts for hostname: undefined method `kernel_fact_value' for Facter::Util::Processor:Module." I think the solution for puppet/facter is #14 . That is, if the user wants to use system ruby, we install the versions of puppet and facter that are known to work locally to the user. |
I think that the "make it work" approach is clear here. The dev-tools should add the puppet group. I would suggest taking the "make it work" approach and actually make it work instead of discussing it ;) Actually in the beaker task I do exactly that (add the puppet group) until dev-tools decide it's worth fixing. |
Yeah, we should just add the puppet group. If people complain about it, we can look for a better solution later. |
Error: Could not set 'directory' on ensure: Could not find group puppet
Error: Could not set 'directory' on ensure: Could not find group puppet
Wrapped exception:
Could not find group puppet
Error: /File[/var/lib/puppet/log]/ensure: change from absent to directory failed: Could not set 'directory' on ensure: Could not find group puppet
Debug: /File[/etc/puppet/ssl/private]/ensure: created
Debug: /File[/etc/puppet/ssl/certificate_requests]/ensure: created
Debug: Finishing transaction 25072740
Error: Got 3 failure(s) while initializing: Could not set 'directory' on ensure: Could not find group puppet; Could not set 'directory' on ensure: Could not find group puppet
Wrapped exception:
Could not find group puppet; change from absent to directory failed: Could not set 'directory' on ensure: Could not find group puppet
The text was updated successfully, but these errors were encountered: