From 2601e0420809d8566fe77f0a5e4d5351dc380cb2 Mon Sep 17 00:00:00 2001 From: Dominic Reber Date: Tue, 7 Nov 2023 07:23:01 +0100 Subject: [PATCH 1/3] chore: remove unecessary tests --- .../test/cpp/test_component_interface.cpp | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/source/modulo_components/test/cpp/test_component_interface.cpp b/source/modulo_components/test/cpp/test_component_interface.cpp index 043664414..dc0ed40fd 100644 --- a/source/modulo_components/test/cpp/test_component_interface.cpp +++ b/source/modulo_components/test/cpp/test_component_interface.cpp @@ -43,31 +43,6 @@ class ComponentInterfaceTest : public ::testing::Test { using NodeTypes = ::testing::Types; TYPED_TEST_SUITE(ComponentInterfaceTest, NodeTypes); -// TODO this needs to be tested on component level now -// TYPED_TEST(ComponentInterfaceTest, RatePeriodParameters) { -// std::shared_ptr component; -// auto node_options = rclcpp::NodeOptions(); -// component = make_component_interface(node_options); -// EXPECT_EQ(component->template get_parameter_value("rate"), 10); -// EXPECT_EQ(component->template get_parameter_value("period"), 0.1); - -// node_options = rclcpp::NodeOptions().parameter_overrides({rclcpp::Parameter("rate", 200)}); -// component = make_component_interface(node_options); -// EXPECT_EQ(component->template get_parameter_value("rate"), 200); -// EXPECT_EQ(component->template get_parameter_value("period"), 0.005); - -// node_options = rclcpp::NodeOptions().parameter_overrides({rclcpp::Parameter("period", 0.01)}); -// component = make_component_interface(node_options); -// EXPECT_EQ(component->template get_parameter_value("rate"), 100); -// EXPECT_EQ(component->template get_parameter_value("period"), 0.01); - -// node_options = -// rclcpp::NodeOptions().parameter_overrides({rclcpp::Parameter("rate", 200), rclcpp::Parameter("period", 0.01)}); -// component = make_component_interface(node_options); -// EXPECT_EQ(component->template get_parameter_value("rate"), 200); -// EXPECT_EQ(component->template get_parameter_value("period"), 0.005); -// } - TYPED_TEST(ComponentInterfaceTest, AddBoolPredicate) { this->component_->add_predicate("foo", true); auto predicate_iterator = this->component_->predicates_.find("foo"); From dfb036664377e8fa7fc513f8b1eb7671a9755201 Mon Sep 17 00:00:00 2001 From: Dominic Reber Date: Tue, 7 Nov 2023 07:23:19 +0100 Subject: [PATCH 2/3] build: try cheaper runner --- .github/workflows/build-release.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml index 209faaec8..555163e2a 100644 --- a/.github/workflows/build-release.yaml +++ b/.github/workflows/build-release.yaml @@ -69,9 +69,8 @@ jobs: matrix: arch: [amd64, arm64] include: - # FIXME (#33): high memory usage during build - image: ubuntu-latest - - image: buildjet-8vcpu-ubuntu-2204-arm + - image: buildjet-4vcpu-ubuntu-2204-arm arch: arm64 runs-on: ${{ matrix.image }} From 68ab0ac8aef83292646ee8d6c5c93734b2e8a6ee Mon Sep 17 00:00:00 2001 From: Dominic Reber Date: Tue, 7 Nov 2023 07:25:31 +0100 Subject: [PATCH 3/3] docs: update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 40bbbeb59..64aedf907 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ Release Versions: ## Upcoming changes (in development) +- chore: remove unnecessary tests (#63) - Remove callback group for topics and services (#61) - Avoid conflict with get_parameter (#42) - Revise ComponentInterface by moving implementations to source file (#39)