Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with how identifier's case is handled #32

Open
airblade opened this issue Feb 6, 2023 · 0 comments
Open

Inconsistency with how identifier's case is handled #32

airblade opened this issue Feb 6, 2023 · 0 comments

Comments

@airblade
Copy link
Owner

airblade commented Feb 6, 2023

The identifier (e.g. email or username) has a case-insensitive uniqueness validation.

However when someone logs in, the account is looked up by a case-sensitive finder.

I think it is up to the application to decide whether the identifier should be case sensitive or not, perhaps using Rails 7.1's normalizes attribute feature. Therefore the validation which Quo Vadis sets up (linked above) should take its case sensitivity from the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant