Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to subclass #24

Open
airblade opened this issue Jun 6, 2023 · 3 comments
Open

Not possible to subclass #24

airblade opened this issue Jun 6, 2023 · 3 comments

Comments

@airblade
Copy link
Owner

airblade commented Jun 6, 2023

The controller adds some actions itself to avoid the user having to add them in their markup.

However these have the name of the controller hardcoded. For example:

let action = 'click->datepicker#toggle'

This means a child controller won't work properly.

@Yasser
Copy link
Contributor

Yasser commented Jun 7, 2023

Probably makes sense to add the action via an EventListener rather than markup?

@airblade
Copy link
Owner Author

airblade commented Jun 7, 2023

Yes, I agree.

I quite liked just being able to set an attribute to add an event listener ;)

@Yasser
Copy link
Contributor

Yasser commented Jun 7, 2023

Still could, just use click->${this.identifier}#toggle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants