Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: options to specify if a check should prevent bundle from being shared or just show in log #18

Open
peps1 opened this issue Jan 25, 2021 · 2 comments

Comments

@peps1
Copy link

peps1 commented Jan 25, 2021

Right now when checking a bundle, if any of the validation checks fail the bundle is not shared.

As some checks though can be considered more FYI than others, like "no nfo" and "multiple nfo", it would be nice to have an option to tell it to still share those and just print the info about missing/multiple nfo to log.

Maybe just another toggle in the settings for each of these.

@peps1
Copy link
Author

peps1 commented Jul 7, 2021

i'm looking into this now, seems easiest way is to just change the current boolean settings to string and have 3 options.

  • disabled
  • announce only
  • announce and don't share bundle

image

@maksis: any concerns?

@maksis
Copy link
Member

maksis commented Dec 30, 2021

There will hopefully soon be new functionality that will allow blocked directories to be added in share manually. That will also include listeners that are fired when a directory is being blocked during refresh (this is already available for blocked finished bundles).

I'd prefer having a separate extension that can then handle the cases when the release validator detects that something is wrong. The best way to handle it might be to use an external release database to check whether the content is valid (and force such releases to be added share).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants