Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the dex.baremetal.local /etc/hosts patch to the virtual test sites #149

Open
mattmceuen opened this issue May 19, 2021 · 3 comments
Open
Assignees
Labels
bug Something isn't working priority/medium Default priority for items size m 2-5 days [moderate complexity, generic code, or enhancement to existing feature]]
Milestone

Comments

@mattmceuen
Copy link
Contributor

mattmceuen commented May 19, 2021

The oidc-apiserver-flags.json patch, which configures the apiserver to delegate auth to Dex, currently lives in the airship-core controlplane definition as of this writing, and is moving to the k8scontrol-ha function as part of this patch.

The API server needs to be configured with a "public" URL for dex, so that it can be reachable as part of the OIDC authentication process. In the real world, this will be a public DNS-resolvable name. For our gates, however, we currently rely on adding dex.function.local and dex.baremetal.local to the /etc/hosts file, mocking a DNS name.

Today that patching is done at the type level -- this isn't ideal, since it will result in those host entries being added to real deployments as well. This issue is to move those particular patches to the virtual test site definitions.

This is a simple change and it would be good to get into the 2.1 release.

TODO: see if we could instead use a dex url of e.g. https://10.23.25.102:32556/dex, in which case we would never need to touch the hosts file.

@mattmceuen mattmceuen added bug Something isn't working triage labels May 19, 2021
@mattmceuen mattmceuen added this to the v2.1 milestone May 19, 2021
@mattmceuen mattmceuen changed the title Make the Dex ingress VIP configurable Move the dex.baremetal.local /etc/hosts patch to the virtual test sites May 19, 2021
@drewwalters96
Copy link
Contributor

It looks like this may be a start on this: https://review.opendev.org/c/airship/treasuremap/+/792067

@drewwalters96 drewwalters96 self-assigned this May 24, 2021
@drewwalters96
Copy link
Contributor

I took a slightly different approach than the patch above that seems to be what we need for now: https://review.opendev.org/c/airship/treasuremap/+/792828

As mentioned in the original issue, this should probably be a URL in the future

@mattmceuen
Copy link
Contributor Author

This will be a temporary fix. Long term we want to use a coredns pod running on the base VM, which can replace this one.

@mattmceuen mattmceuen added priority/low Items that are considered non-critical for functionality, such as quality of life improvements and removed triage labels May 26, 2021
@mattmceuen mattmceuen added priority/medium Default priority for items and removed priority/low Items that are considered non-critical for functionality, such as quality of life improvements labels May 26, 2021
@drewwalters96 drewwalters96 added the size m 2-5 days [moderate complexity, generic code, or enhancement to existing feature]] label Jun 7, 2021
@lb4368 lb4368 modified the milestones: v2.1, Future Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/medium Default priority for items size m 2-5 days [moderate complexity, generic code, or enhancement to existing feature]]
Projects
None yet
Development

No branches or pull requests

3 participants