Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure topic params in confluent create_topics #1827

Open
kumaranvpl opened this issue Oct 2, 2024 · 0 comments
Open

Ability to configure topic params in confluent create_topics #1827

kumaranvpl opened this issue Oct 2, 2024 · 0 comments
Assignees
Labels
Confluent Issues related to `faststream.confluent` module good first issue Good for newcomers

Comments

@kumaranvpl
Copy link
Collaborator

Currently if the topic doesn't exists we create it with num_partitions and replication_factor set to 1 -

def create_topics(
topics: List[str],
config: Dict[str, Optional[Union[str, int, float, bool, Any]]],
logger_: Optional["LoggerProto"] = None,
) -> None:
logger_ = logger_ or faststream_logger
"""Creates Kafka topics using the provided configuration."""
admin_client = AdminClient(
{x: config[x] for x in ADMINCLIENT_CONFIG_PARAMS if x in config}
)
fs = admin_client.create_topics(
[NewTopic(topic, num_partitions=1, replication_factor=1) for topic in topics]
)
. We should provide a way for users to configure the num_partitions and replication_factor for each topic if possible.

Based on #1821

@kumaranvpl kumaranvpl self-assigned this Oct 2, 2024
@kumaranvpl kumaranvpl converted this from a draft issue Oct 2, 2024
@Lancetnik Lancetnik added good first issue Good for newcomers Confluent Issues related to `faststream.confluent` module labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confluent Issues related to `faststream.confluent` module good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

2 participants