Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Toolbar help item #5

Open
neocotic opened this issue May 25, 2011 · 1 comment
Open

Toolbar help item #5

neocotic opened this issue May 25, 2011 · 1 comment

Comments

@neocotic
Copy link

I've noticed that clicking this tiny icon doesn't actually do anything but open an empty popup when clicked (at least for me anyway). I've tried multiple different examples but never loads anything inside the popup and the following error is always logged in the console;

Uncaught TypeError: Cannot call method 'focus' of undefined
e.toolbar.items.help.execute:1
e.toolbar.handler:1
h:1

I realise that the SyntaxHighlighter library is responsible for this but it may be more user-friendly to hide the toolbar altogether;

shCore.css

.syntaxhighlighter .toolbar {
  display: none !important;
}

Obviously it might be nicer to overload its functionality instead to provide the user with bespoke help, but I realise shCore.js is almost impossible to edit for the latest version.

@neocotic
Copy link
Author

After reading through the SyntaxHighlighter configuration instructions I believe that this could also be achieved with one of the following;

Append ; toolbar: false to the class attribute found on content_script.js:48.

Or...

Insert SyntaxHighlighter.defaults['toolbar'] = false; before content_script.js:64.

I believe either of these options would work and provide a better alternative to my previous suggestion as avoids hacking SyntaxHighlighter content.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants