Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for interlacing #2

Open
Ketorin opened this issue Nov 5, 2016 · 5 comments
Open

No support for interlacing #2

Ketorin opened this issue Nov 5, 2016 · 5 comments
Assignees

Comments

@Ketorin
Copy link

Ketorin commented Nov 5, 2016

Would it be a lot of work if support for interlaced modes was added?

Some people would need it, I would need it. (CRT projector, 1080 lines interlaced.)

Meanwhile, I'm studying your work and alternative ways to spoof the EDID.

@akatrevorjay
Copy link
Owner

Ah, yeah, interlaced should be supported as is, what modeline are you handing it?
Ty,
Trevor

@substring
Copy link

Hi,

sorry to necro this issue, but I have a fix ! First apply this patch :

diff --git a/edid.S b/edid.S
index ef082dc..d1adf9e 100644
--- a/edid.S
+++ b/edid.S
@@ -237,7 +237,7 @@ y_border:   .byte   0
    Bit 1       If analog sync: Sync on all 3 RGB lines (else green only)
    Digital: HSync polarity (1=positive)
    Bit 0       2-way line-interleaved stereo, if bits 4-3 are not 00. */
-features:      .byte   0x18+(VSYNC_POL<<2)+(HSYNC_POL<<1)
+features:      .byte   FEATURES+(VSYNC_POL<<2)+(HSYNC_POL<<1)
 
 descriptor2:   .byte   0,0     /* Not a detailed timing descriptor */
                .byte   0       /* Must be zero */

This allows to use a #define FEATURES inside your .S like:

#define FEATURES 0x18 | 1<<7

See how I've enabled the interlace bit (number 7) for the features byte with 1<<7. I'm not sure how the sync bits (the 0x18) work, they could have stayed in the edid.S rather than in my own edid .S

I can submit a PR if you wish.

@STPKITT
Copy link

STPKITT commented Oct 27, 2023

Please could this patch be integrated? Without interlace support people trying to use this great tool for interlaced monitors/TVs are stuck.

@akatrevorjay
Copy link
Owner

@STPKITT @substring Want to put up a patch?
I'm happy to accept this if you can wire it up as an option to declare this

@substring
Copy link

Oh God that was aeons ago ... May have a look at it eventually, but it would be best to add a commandline parameter to ask for an interlaced resolution. Just applying the change like this would make all resolutions interlaced, and we don't want that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants