Roundcube 1.1.0 Error

[ghost]

Hello,

No errors with config but wen i try to see quarantine, i've got this errors
PHP Error: No handler found for action quarantine.index in /usr/share/roundcubemail/program/lib/Roundcube/rcube_plugin_api.php on line 463 (GET /roundcubemail/?_task=quarantine)
OR
PHP Error: No handler found for action plugin.amacube-quarantine in /usr/share/roundcubemail/program/lib/Roundcube/rcube_plugin_api.php on line 463 (GET /roundcubemail/?_task=quarantine&_action=plugin.amacube-quarantine)

Do you have an idea ?

[frijsdijk]

Same here, with 1.1.0 Roundcube version.

[blake]

Hi,

I'm trying to dig into why this broke. What version of Roundcube were you running prior to 1.1.0?

[frijsdijk]

Not relevant in this case (it was pre 1.x I believe, but wasn't using the amacube plugin then anyway). Started to use it with 1.1.0 (fresh install)

[blake]

Hi, I found why this plugin no longer works on Roundcube 1.1.0. It is due to how amacube registers the quarantine action with Roundcube, and how Roundcube tries to incorrectly process that action. It broke after this commit to Roundcube.

roundcube/roundcubemail@a873d93

I'm very new to the Roundcube codebase, but it seems the proper fix for this is to patch Roundcube. I've been able to make this plugin work again by changing line 275 in Roundcube's index.php to the following:

if (!$RCMAIL->plugins->is_plugin_task($RCMAIL->task) && preg_match('/^plugin./', $RCMAIL->action)) {

I'll send this fix to Roundcube. Hopefully they'll accept it, or direct me to the proper solution.

[frijsdijk]

Ok confirmed. No more errors!

[blake]

My previous fix was not the proper solution. The Roundcube devs clarified the behavior of their code, and I now understand that the problem lies with amacube. I've fixed the plugin so that it properly functions on 1.1.x, and the older 1.0.x releases. You can find it here.

https://github.com/blake/amacube/tree/rcube-v1.1-compat

[frijsdijk]

Great. Works!

[ghost]

my Roundcube 1.1.3 still got this error

PHP Notice: Undefined index: noshow in /webmail/program/include/rcmail_output_html.php on line 1046, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined index: render_page in /webmail/program/lib/Roundcube/rcube_plugin_api.php on line 406, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined offset: 4 in /webmail/program/lib/Roundcube/html.php on line 330, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined index: request_token in /webmail/program/lib/Roundcube/rcube_plugin_api.php on line 406, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined index: nl in /webmail/program/lib/Roundcube/html.php on line 78, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined index: config_get in /webmail/program/lib/Roundcube/rcube_plugin_api.php on line 406, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined index: _unlock in /webmail/program/include/rcmail_output_html.php on line 654, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined variable: parent_prefix in /webmail/program/include/rcmail_output_html.php on line 685, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined index: framed in /webmail/program/include/rcmail_output_html.php on line 507, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined index: noclose in /webmail/program/lib/Roundcube/html.php on line 82, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined index: foot in /webmail/program/include/rcmail_output_html.php on line 1564, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined variable: is_empty in /webmail/program/include/rcmail_output_html.php on line 1613, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined variable: add in /webmail/program/lib/Roundcube/rcube_db.php on line 905, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX
PHP Notice: Undefined property: rcube_session::$gc_enabled in /webmail/program/lib/Roundcube/rcube_session.php on line 415, referer: http://mail.mail.com/?_task=mail&_mbox=INBOX