-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One-click promotion of a Stage's current piece of Freight to its downstream #3224
Comments
I think something else you'd proposed in #3193 is that one click "push downstream" would only be available for Stages that have only one Freight request.
The existing "Promote to Stage" and "Promote to Downstream" endpoints both take just three arguments: Project name, Stage Name, Freight name. So the existing endpoints should handle this just fine without a single change. Your proposed feature would just be a shortcut to filling in the Freight name argument. cc @jessesuen to get impressions on the value of such a feature. cc @Marvin9 to think about what UI for something like this might look like. It would be very important to distinguish between "select Freight to promote downstream" vs "promote the Freight the Stage currently has to downstream." |
@Marvin9 don't we already put something there on the right (only if the Stage has multiple downstreams, iirc)? That existing action is the thing I want to avoid confusion with. |
Right @krancour that is truck icon on the edge of node.. this will be right besides the freight text that user wants to promote in one click.. it'd be as self-explanatory as possible |
Thanks for clarifying @Marvin9! |
Yeah, when creating this issue I was not sure if we wanted to design this in a general manner for all types of Stages or limit it to Stages with only one Freight. But I guess @Marvin9's suggestion of putting it beside the Freight text makes it unambiguous and still solves it in a general manner. I'll update the title and initial post to reflect that it's only one Freight request. |
I think the stages will show multiple freight if they have them, so if there's a one-click "promote downstream" button next to each, then I think we don't have to limit it to Stages that request Freight from only one source. There's our general solution. |
Checklist
kargo version
, if applicable.Proposed Feature
Allow the user to click one button, which will take the piece of Freight currently in a Stage and promote it downstream.
This capability can be provided in both UI and CLI.
Motivation
This eliminates the need for the user to find the current piece of Freight in a stage and supply that as input when requesting a Promotion. This will greatly improve the user experience when manually promoting what is already in a Stage to its downstream. Especially when the action has to be repeated on multiple DAGs.
From #3193 (comment)
Suggested Implementation
It could be a purely cosmetic change which uses existing APIs, but it would perhaps be better to introduce new API to implement this feature server-side.
The text was updated successfully, but these errors were encountered: