Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test files #35

Open
alchem0x2A opened this issue Mar 19, 2021 · 10 comments
Open

New test files #35

alchem0x2A opened this issue Mar 19, 2021 · 10 comments

Comments

@alchem0x2A
Copy link
Owner

It would be of great help if more test wdf files can be included in the repo to debug different WiRE versions / data types. @expert-git

@expert-main
Copy link
Contributor

sorry, because of security, I can't share file right now, but I will try.

@alchem0x2A
Copy link
Owner Author

I'm definitely fine with that. feel free to close the issue if it is infeasible.

@expert-main
Copy link
Contributor

expert-main commented Mar 19, 2021

Thanks for understanding.

@ericpre
Copy link
Contributor

ericpre commented Apr 24, 2021

It would be good to add a test suite too. I should be able to help with sourcing test file - I am not acquiring the data myself but I can ask someone else to provide these files.

@alchem0x2A
Copy link
Owner Author

@ericpre Thanks for your help!

@expert-main
Copy link
Contributor

I am going to provide more example files, but couldn't push because of file size limit.

@expert-main
Copy link
Contributor

@alchem0x2A I created new PR and uploaded some example files, but I see there are issues on this repo and would like to update.

@alchem0x2A
Copy link
Owner Author

hi @expert-git thanks for your file uploads! To keep the size of our repo I would prefer to only provide the wdf files as optional binary release assets for downloading https://github.com/alchem0x2A/py-wdf-reader/releases/tag/binary.

Currently I'm busy with other personal things so updating will be delayed, I'll let you know once there I merge your test files with the master branch. If you have example codes to add please feel free to update your PR. thanks again!

@expert-main
Copy link
Contributor

Thanks for response @alchem0x2A
I have got two problems.

  • MeasurementType in types.py is not correct.
    In order to compare with .wdf and .spc data, I tried to upload both of two files. spc file was generated by software from .wdf file, so it will be helpful to catch issues what's wrong.
  • extracting spectra data is not accurate
    one value is missing, so it's necessary for me to contact and share some knowledges.

@expert-main
Copy link
Contributor

@alchem0x2A I would like to let me know when you are available to connect to discuss about errors.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants