-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nan in the load_expanded_ensemble_case_1 dataset #185
Comments
Do you suspect that there's something wrong with the data? |
@orbeckst I think there are NaNs in the dataset as dropna would alter the size of the dataset. |
Did you check that this is what happens? Then the next stage would be to contact the original authors to verify that these nans belong there. Once this is all confirmed we can consider changing the test answers. |
@xiki-tempula please remind me, what do we have to do here? In PR #184 we learned that the NAN should not really be in the dataset. But with #171 solved (PR #183) we can use the dataset. Maybe we only need to add a note in alchemtest that the dataset contains NAN? |
Nothing else to do here... |
One would assume that there shouldn't be any NaNs in the test data set, but simply removing the NaNs from the load_expanded_ensemble_case_1 dataset would make some tests fail. See #184
The text was updated successfully, but these errors were encountered: