Add Custom Search Attributes to TemporalNamespace

[dmytro-orlenko]

Custom Search Attributes as a part of namespace and can help to search workflow by attributes

apiVersion: temporal.io/v1beta1
kind: TemporalNamespace
metadata:
  name: default
spec:
  clusterRef:
    name: temporal
  description: Default namespace
  retentionPeriod: 336h #14 days
  allowDeletion: false
  customSearchAttributes:
    key: value

[sandhyabakash]

+1 This would be a very useful feature.

[alexandrevilain]

Hi @dmytro-orlenko !

Good idea! Are you interested on contributing for this feature?

[vinimona]

@alexandrevilain Really appreciate your efforts in addressing the issues!! I think it would be really convenient to be able to add custom search attributes via the TemporalNamespace manifest. Thanks.

[dmytro-orlenko]

@alexandrevilain I'm not sure about my changes, can you help me with it? #602

[alexandrevilain]

Hi @dmytro-orlenko !

Thanks for your contribution.
Looks like you took the wrong direction, RegisterNamespaceRequest and UpdateNamespaceRequest does not provide the CustomSearchAttributes field. See: https://pkg.go.dev/go.temporal.io/api/workflowservice/v1#RegisterNamespaceRequest

According to the temporal documentation about search attributes, the command to use is: temporal operator search-attribute create --name CustomSA --type Keyword --namespace yournamespace.

After a quick look at the cli's codebase, we can find the code handling this in the cli, see: https://github.com/temporalio/cli/blob/main/searchattribute/search_attribute_commands.go#L62

Looks like the search attribute reconciliation should be done in another step, after the namespace has been created :)

Hope it helps.

[dmytro-orlenko]

It looks more complicated than I thought

[alexandrevilain]

I can help you implementing this @dmytro-orlenko :)

[TheHiddenLayer]

fyi @alexandrevilain, i'm planning to start work on this in the near term

[TheHiddenLayer]

@alexandrevilain apologies for the delay. I've implemented custom search attributes in my fork.

Based on my light manual testing, looks like it works 😄. The only thing that's making me hesitate to make the PR is some more testing. Will do more manual testing tomorrow, and will probably need to write some code test in tests/e2e/namespace_test.go.

wdyt?

[alexandrevilain]

Cool @TheHiddenLayer ! Thanks for your work!

Feel free to open a Draft pull request ;)
For sure unit and e2e tests are always welcomed and encouraged ;)