From d3a3f5936d0b56226c06f1377c5e93cb1536e37b Mon Sep 17 00:00:00 2001
From: Ryan Muther <ryan_muther@fas.harvard.edu>
Date: Wed, 11 Dec 2024 11:31:32 -0500
Subject: [PATCH 1/6] Added aria label to hits per page dropdown

---
 packages/react-instantsearch/src/ui/HitsPerPage.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/react-instantsearch/src/ui/HitsPerPage.tsx b/packages/react-instantsearch/src/ui/HitsPerPage.tsx
index 2aa8750617..4c66c871a3 100644
--- a/packages/react-instantsearch/src/ui/HitsPerPage.tsx
+++ b/packages/react-instantsearch/src/ui/HitsPerPage.tsx
@@ -39,6 +39,7 @@ export function HitsPerPage({
     >
       <select
         className={cx('ais-HitsPerPage-select', classNames.select)}
+        aria-label="Items per page"
         onChange={(event) => {
           onChange(Number(event.target.value));
         }}

From 72f53a33fbea6fddcee0448d59d44da1ae5d825c Mon Sep 17 00:00:00 2001
From: Ryan Muther <ryan_muther@fas.harvard.edu>
Date: Wed, 11 Dec 2024 11:37:08 -0500
Subject: [PATCH 2/6] Added to vue component as well

---
 packages/vue-instantsearch/src/components/HitsPerPage.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/vue-instantsearch/src/components/HitsPerPage.vue b/packages/vue-instantsearch/src/components/HitsPerPage.vue
index 827dbef966..47d30be0fc 100644
--- a/packages/vue-instantsearch/src/components/HitsPerPage.vue
+++ b/packages/vue-instantsearch/src/components/HitsPerPage.vue
@@ -9,6 +9,7 @@
     >
       <select
         :class="suit('select')"
+        aria-label="Items per page"
         @change="state.refine(Number($event.currentTarget.value))"
       >
         <option

From 176d45b6c60e8945b554c7ae5fa1c475835cabe1 Mon Sep 17 00:00:00 2001
From: Ryan Muther <ryan_muther@fas.harvard.edu>
Date: Wed, 11 Dec 2024 11:37:08 -0500
Subject: [PATCH 3/6] Fix(hitsperpage) Added Aria label to vue component as
 well

---
 packages/vue-instantsearch/src/components/HitsPerPage.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/vue-instantsearch/src/components/HitsPerPage.vue b/packages/vue-instantsearch/src/components/HitsPerPage.vue
index 827dbef966..47d30be0fc 100644
--- a/packages/vue-instantsearch/src/components/HitsPerPage.vue
+++ b/packages/vue-instantsearch/src/components/HitsPerPage.vue
@@ -9,6 +9,7 @@
     >
       <select
         :class="suit('select')"
+        aria-label="Items per page"
         @change="state.refine(Number($event.currentTarget.value))"
       >
         <option

From f2209bbbaa011715c786bbd28dca834045972494 Mon Sep 17 00:00:00 2001
From: Ryan Muther <ryan_muther@fas.harvard.edu>
Date: Wed, 11 Dec 2024 13:26:52 -0500
Subject: [PATCH 4/6] Updated test

---
 .../react-instantsearch/src/ui/__tests__/HitsPerPage.test.tsx  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/react-instantsearch/src/ui/__tests__/HitsPerPage.test.tsx b/packages/react-instantsearch/src/ui/__tests__/HitsPerPage.test.tsx
index b25724da01..3214c43260 100644
--- a/packages/react-instantsearch/src/ui/__tests__/HitsPerPage.test.tsx
+++ b/packages/react-instantsearch/src/ui/__tests__/HitsPerPage.test.tsx
@@ -38,6 +38,7 @@ describe('HitsPerPage', () => {
         >
           <select
             class="ais-HitsPerPage-select"
+            aria-label="Items per page"
           >
             <option
               class="ais-HitsPerPage-option"
@@ -112,7 +113,7 @@ describe('HitsPerPage', () => {
           class="ais-HitsPerPage ROOT MyCustomHitsPerPage"
         >
           <select
-            class="ais-HitsPerPage-select SELECT"
+            class="ais-HitsPerPage-select aria-label="Items per page" SELECT"
           >
             <option
               class="ais-HitsPerPage-option OPTION"

From f0d2b33c57999ecaaa1999f9aa2d85088f6157c4 Mon Sep 17 00:00:00 2001
From: Ryan Muther <ryan_muther@fas.harvard.edu>
Date: Wed, 11 Dec 2024 14:09:25 -0500
Subject: [PATCH 5/6] feat(hitsbypage) Added to plain js implementation as well

---
 .../instantsearch.js/src/widgets/hits-per-page/hits-per-page.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/instantsearch.js/src/widgets/hits-per-page/hits-per-page.tsx b/packages/instantsearch.js/src/widgets/hits-per-page/hits-per-page.tsx
index 1ee3f6efec..17298b02f5 100644
--- a/packages/instantsearch.js/src/widgets/hits-per-page/hits-per-page.tsx
+++ b/packages/instantsearch.js/src/widgets/hits-per-page/hits-per-page.tsx
@@ -42,6 +42,7 @@ const renderer =
       <div className={cssClasses.root}>
         <Selector
           cssClasses={cssClasses}
+          ariaLabel='Items per page'
           currentValue={currentValue}
           options={items}
           // @ts-expect-error: the refine function expects a number, but setValue will call it with a string. We don't want to change the type of the refine function because it's part of the connector API.

From 025ce1b4ab05459d131789065190d3b036247415 Mon Sep 17 00:00:00 2001
From: Ryan Muther <ryan_muther@fas.harvard.edu>
Date: Wed, 11 Dec 2024 15:52:54 -0500
Subject: [PATCH 6/6] feat(hits per page) updated tests

---
 .../src/ui/__tests__/HitsPerPage.test.tsx                    | 5 +++--
 tests/common/widgets/hits-per-page/options.ts                | 2 ++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/react-instantsearch/src/ui/__tests__/HitsPerPage.test.tsx b/packages/react-instantsearch/src/ui/__tests__/HitsPerPage.test.tsx
index 3214c43260..7d22b82fd5 100644
--- a/packages/react-instantsearch/src/ui/__tests__/HitsPerPage.test.tsx
+++ b/packages/react-instantsearch/src/ui/__tests__/HitsPerPage.test.tsx
@@ -37,8 +37,8 @@ describe('HitsPerPage', () => {
           class="ais-HitsPerPage"
         >
           <select
-            class="ais-HitsPerPage-select"
             aria-label="Items per page"
+            class="ais-HitsPerPage-select"
           >
             <option
               class="ais-HitsPerPage-option"
@@ -113,7 +113,8 @@ describe('HitsPerPage', () => {
           class="ais-HitsPerPage ROOT MyCustomHitsPerPage"
         >
           <select
-            class="ais-HitsPerPage-select aria-label="Items per page" SELECT"
+            aria-label="Items per page"
+            class="ais-HitsPerPage-select SELECT"
           >
             <option
               class="ais-HitsPerPage-option OPTION"
diff --git a/tests/common/widgets/hits-per-page/options.ts b/tests/common/widgets/hits-per-page/options.ts
index 0a6d02e268..1d30d20bd6 100644
--- a/tests/common/widgets/hits-per-page/options.ts
+++ b/tests/common/widgets/hits-per-page/options.ts
@@ -41,6 +41,7 @@ export function createOptionsTests(
           class="ais-HitsPerPage"
         >
           <select
+            aria-label="Items per page"
             class="ais-HitsPerPage-select"
           >
             <option
@@ -94,6 +95,7 @@ export function createOptionsTests(
           class="ais-HitsPerPage"
         >
           <select
+            aria-label="Items per page"
             class="ais-HitsPerPage-select"
           >
             <option