New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

代码仓库中存在大量的defer recover操作，而且很多地方不是必要的，defer也是有性能开销的... #590

Open

qshuai opened this issue Jan 17, 2025 · 0 comments

qshuai commented Jan 17, 2025

比如这个地方，有什么必要recover吗？如果是map存在并发问题，也recover不了呀。
https://github.com/alibaba/sentinel-golang/blob/master/api/tracer.go#L40-L45

其实这个项目在业务中还是很有用的，这个要给与肯定。
但是代码质量真的像是刚学习go的同学写的，和其他开源项目比起来差了很多，
真的不像是阿里的水平。

这里没有冒犯的意思哈，真心希望好好打造一下。对你们的辛苦表示真心的感谢！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment