-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve use of jekyll liquid tags #1502
Labels
Comments
george-gca
pushed a commit
that referenced
this issue
Apr 29, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to #1502.
BoAi01
pushed a commit
to BoAi01/boai01.github.io
that referenced
this issue
May 7, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this issue
Jun 19, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
karapostK
pushed a commit
to karapostK/karapostK.github.io
that referenced
this issue
Jul 4, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
Suraj-Bhor
pushed a commit
to Suraj-Bhor/suraj-bhor.github.io
that referenced
this issue
Aug 13, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
meiqing-wang
pushed a commit
to meiqing-wang/meiqing-wang.github.io
that referenced
this issue
Oct 13, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
avishekanand
pushed a commit
to avishekanand/al-folio-homepage
that referenced
this issue
Oct 22, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
mattleblanc
pushed a commit
to mattleblanc/mattleblanc.github.io
that referenced
this issue
Dec 29, 2024
This PR fixes a very niche bug. If there is a co-author that is not *me* (=`<em>` tagged) and does not have a `coauthor_url` (=`<a>` tagged), there will be a leading whitespace before the separating comma. If the author list is split into multiple lines (due to long author lists or a small view), the whitespace can lead to a line beginning with a comma. As I said, very niche, but interestingly, the other cases already did the same whitespace handling. Just the case not-me/no-url was mising. Currently, we do not have this case on vanilla al-folio, but you can see it for example on [my website](https://christianmainka.de/publications/) if the view is small (e.g., 430px). Related to alshedivat#1502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just realized that I've been using the tags somewhat wrong. Not wrong, but it could be better. As I saw posted here, simply using
{%- ... -%}
instead of{% ... %}
reduces the whitespaces created by jekyll.This is not that simple though, since I tried a dumb replace all in our code, and it stopped showing things correctly. I'll leave it here as a reminder that this change might be applied in a lot of different places, but maybe not all of them.
The text was updated successfully, but these errors were encountered: