Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in order of operations for snow density #123

Open
ecoon opened this issue Mar 31, 2022 · 0 comments
Open

bug in order of operations for snow density #123

ecoon opened this issue Mar 31, 2022 · 0 comments
Assignees

Comments

@ecoon
Copy link
Collaborator

ecoon commented Mar 31, 2022

Current master has a bug in the PVFE kept by surface_balance_implicit_subgrid PK. The PVFE for snow density is actually the OLD state, not the NEXT state. Therefore, when it is tagged as "changed," no change is actually registered.

This bug avoids a weird loop, whereby:

  1. snow PK requests update of snow-source_sink
  2. this triggers update of SEB evaluator
  3. after this update, the snow PK changes snow-density
  4. then the flow PKs request update of snow-source_sink, which, because it depends on snow density, is updated again.

It seems that this cycle should be broken somehow, but currently it is broken by a bug.

@ecoon ecoon self-assigned this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant