Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oddity in ordering of coupled transport #125

Open
ecoon opened this issue Apr 11, 2022 · 0 comments
Open

oddity in ordering of coupled transport #125

ecoon opened this issue Apr 11, 2022 · 0 comments
Assignees
Labels
reactive-transport-roundup Low-hanging fruit for quick fixups in ATS Integrated Reactive Transport

Comments

@ecoon
Copy link
Collaborator

ecoon commented Apr 11, 2022

Currently, the expectation of coupled transport is that the subsurface PK is listed first, and then it is hard-coded to always do the surface transport PK first in AdvanceStep()

This is backwards -- if AdvanceStep() on the surface needs to be done first (which is consistent with all other PKs) then it seems that it should be listed first. The potential exception would be if Setup() and/or Initialize() of the subsurface needed to be done first, but this would need to be justified and documented.

@ecoon ecoon self-assigned this Apr 11, 2022
@ecoon ecoon added the reactive-transport-roundup Low-hanging fruit for quick fixups in ATS Integrated Reactive Transport label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reactive-transport-roundup Low-hanging fruit for quick fixups in ATS Integrated Reactive Transport
Projects
None yet
Development

No branches or pull requests

1 participant