Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcrypt broken: Not re-entrant. #7

Open
rzwitserloot opened this issue May 22, 2017 · 0 comments
Open

bcrypt broken: Not re-entrant. #7

rzwitserloot opened this issue May 22, 2017 · 0 comments
Assignees
@amdelamar
Labels
bug
Milestone
Version 3.0.0

Comments

@rzwitserloot
Copy link

https://github.com/amdelamar/jhash/blob/master/src/main/java/com/amdelamar/jhash/algorithms/BCrypt.java#L404

Your bcrypt impl isn't re-entrant; calling bcrypt() calls key(), and key overwrites pA, which is a global static mutable variable. Uhoh.
@amdelamar amdelamar added the bug label Jun 1, 2017
@amdelamar amdelamar self-assigned this Dec 19, 2017
@amdelamar amdelamar added this to the Version 2.0.0 milestone Dec 19, 2017
@amdelamar amdelamar modified the milestones: Version 2.0.0, Version 3.0.0 Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amdelamar amdelamar

Labels
bug
Projects
None yet
Milestone
Version 3.0.0
Development

No branches or pull requests
2 participants
@rzwitserloot @amdelamar