-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map multibindings #48
Comments
I don't see why not. |
This is the last reason I can't move my projects away from Dagger+Anvil yet. Is anything required to get the linked PR over the finish line and get a release out with it? I can see there's a question in the PR to add support for |
I'm sorry for the delay, but this gave me a lot of time to think about this request and #86. While Map multibindings as a feature makes sense, the the proposed changes would significantly increase the library's API surface, which I'm hesitant to do for long-term maintainability. We don't use this feature and I'm concerned about the potential for future complexity and the ongoing maintenance burden. But the good thing is, this could be easily implemented as an extension and doesn't need to be part of the core library: https://github.com/amzn/kotlin-inject-anvil?tab=readme-ov-file#custom-symbol-processors For now, I suggest going this route. |
This would be kinda funny and complex situation. Having an addon for an addon for an addon, a 3-tiered dependency injection solution. But I understand your point, thanks for clarifying. |
Any chance a support for contributing to a map multibinding could be added?
Would adding a
key
property to the contributes annotation work?The text was updated successfully, but these errors were encountered: