-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink and overhaul Local IPv4 and IPv6 display #10
Comments
With IPv4 One option would be indeed to try figuring out an way to look up the IP-address that belongs to adapter and/or subnet that has default route pointing in it, but that doesn't make other possible IP-numbers not any less "local" nor unusable. With IPv6 it is then even more "impossible" determination as every adapter can get trough its own "fe80:/0", and all variations of stateless and stateful are also equally usable, thus there is even less clear idea what we want to display as "local" |
Feedback: for whatever reason the new version after the last update to develop, feels much faster |
I found this snippet |
Determine what we actually wanna show/signal with "local" IP numbers, especially IPv6
|
Well... cutting half away fom ipv6 is same as not showing it at all... Also external ipv6 is easy in itself, there is ever only one reported at one time.. "only" local is the thing that is a mess... I'm not against having all those and even more as an option, but from these option 2 is.at least.most sane default :) Also for point 3, sure we could show only latter part of ipv6, but again we don't know how much.. we could try to calculate suffix length from reported subnet length but even that doesn't always tell dies upstream router have bigger subnet and thus part of wanted portion.. so not easy to figure out that at least behalf of anyone... |
I agree, option 2 should be default |
Look at this screenshot from @fikoborizqy . As soon as you have more than one IP, it becomes very ugly |
We need to determine what we exactly mean by "local" in local IP-addresses, as even mine laptop has 2 "local" IPv4-addresses, one for wireless and one from virtual-machine host adapter.
With IPv6-addresses there can easily be 3-6 per adapter, link-local fe80:, local routable fd:, one gotten from DHCPv6 (statefull), one gotten from router-advertisment (stateless), and one from router-advertisment but randomly created... Not every address is allways there depending from configuration and avaibility, but even minimally there is usually 3 addresses, all considered "local"... and multiply by number of adapters you get quite an list quite fast...
So:
The text was updated successfully, but these errors were encountered: