Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current package typings do not match actual module exports #125

Closed
zymotik opened this issue Aug 28, 2024 · 2 comments · Fixed by #126
Closed

Current package typings do not match actual module exports #125

zymotik opened this issue Aug 28, 2024 · 2 comments · Fixed by #126

Comments

@zymotik
Copy link
Contributor

zymotik commented Aug 28, 2024

I'm submitting a ... (check one with "x")

[ ] Bug report => search github for a similar issue or PR before submitting
[ ] Feature request
[x] Other, please describe

Current typings do not match actual module exports.

Current behavior
As defined by types/index.d.ts

export {LoadingPlugin};

export default Component

Expected behavior
Match exports from library at src/index.js, which are:

export default Component;
export {useLoading, LoadingPlugin, Component}
@zymotik
Copy link
Contributor Author

zymotik commented Aug 28, 2024

Referenced in comment on issue #117, see comment.

zymotik added a commit to zymotik/vue-loading-overlay that referenced this issue Sep 1, 2024
@zymotik
Copy link
Contributor Author

zymotik commented Sep 1, 2024

@ankurk91, I have tested the updated typings for app.use and component in our TypeScript based web application and they work. I would appreciate your feedback. See #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant