Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loupe() feedback when no new rows #34

Closed
thomaszwagerman opened this issue Jan 8, 2025 · 1 comment
Closed

Improve loupe() feedback when no new rows #34

thomaszwagerman opened this issue Jan 8, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@thomaszwagerman
Copy link
Collaborator

From the reviewer:

For changed rows, it makes sense because if rows have changed, a message that rows have changed is followed by a list of changed rows. If no rows have changed, we see And there are no differences with previous data. But regardless of whether there are new rows or not, the message is printed The following rows are new in 'df_current': . I would recommend replacing this with There are no new rows in 'df_current' if no rows are new.

See ropensci/software-review#676

@thomaszwagerman thomaszwagerman added the enhancement New feature or request label Jan 8, 2025
@thomaszwagerman thomaszwagerman self-assigned this Jan 8, 2025
@thomaszwagerman
Copy link
Collaborator Author

When there are no new rows, it returns "There are no new rows. Check 'df_current' is your most recent data, and 'df_previous' is your previous data. If comparing directly, try waldo::compare()".

I think this already satisfies the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant