Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation improvements #36

Closed
3 tasks done
thomaszwagerman opened this issue Jan 8, 2025 · 0 comments
Closed
3 tasks done

Documentation improvements #36

thomaszwagerman opened this issue Jan 8, 2025 · 0 comments
Assignees
@thomaszwagerman
Labels
documentation Improvements or additions to documentation

Comments

@thomaszwagerman
Copy link
Collaborator

thomaszwagerman commented Jan 8, 2025 •
edited
Loading

From reviewer comments:

  • Specify what loupe does in the description.
  • Elaborate on all.equal(), in addition to waldo::compare()
  • catch() line 52, replace inner_join() with anti_join()

Other comments included timeline() and timeline_group() renaming, I will cover these separately - pending possible further function naming comments from the other reviewer.

See ropensci/software-review#676
@thomaszwagerman thomaszwagerman added the documentation Improvements or additions to documentation label Jan 8, 2025
@thomaszwagerman thomaszwagerman self-assigned this Jan 8, 2025
@thomaszwagerman thomaszwagerman mentioned this issue Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomaszwagerman thomaszwagerman

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomaszwagerman