Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Trivial) Rename TxName #5230

Open
kevinrr888 opened this issue Jan 7, 2025 · 5 comments · May be fixed by #5273
Open

(Trivial) Rename TxName #5230

kevinrr888 opened this issue Jan 7, 2025 · 5 comments · May be fixed by #5273
Assignees
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Milestone

Comments

@kevinrr888
Copy link
Member

Is your feature request related to a problem? Please describe.
Prior to #5218, a String was passed around and stored representing the type of fate operation being performed. This was changed to be a concrete type. TxName and similar naming are still used throughout the FATE code, which isn't as representative of what is being passed/stored now.

Describe the solution you'd like
All mentions of TxName or similar should be renamed to something more appropriate like fateOp, txOp, txOperation, etc.

@kevinrr888 kevinrr888 added the enhancement This issue describes a new feature, improvement, or optimization. label Jan 7, 2025
@kevinrr888 kevinrr888 added this to the 4.0.0 milestone Jan 7, 2025
@kevinrr888 kevinrr888 self-assigned this Jan 7, 2025
@richochetclementine1315

Hi @kevinrr888 myself Mrinmoy. First of all I want to ask is this issue already assigned to someone??
and secondly...Can you pls explain a bit about this issue??

THANKS :)

@kevinrr888
Copy link
Member Author

Hi @richochetclementine1315
#5218 introduced a new type FateOperation as a replacement to passing around a String. It represents the type of fate operation being performed. For example, if a table is created, this would be a TABLE_CREATE fate operation. TxName, txName, or similar were used throughout the code to represent this previously String type. This is no longer the best way to represent what is being stored or passed around now. fateOp may be the best way to represent this now. Grepping for txname (case insensitive) would be a good starting place to complete this ticket. More info about fate can be found here if curious https://accumulo.apache.org/docs/2.x/administration/fate.

Let me know if you would like me to assign this ticket to you.

@richochetclementine1315

yes...I wanna work upon this issue @kevinrr888 :)

@richochetclementine1315

@kevinrr888 I just did a PR.... Kindly take a look... please feel free to tell if some other changes are required. Thanks!! :)

@richochetclementine1315

hi @kevinrr888... I've made the changes. Please take a look THANKS :)

@ctubbsii ctubbsii linked a pull request Jan 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants