-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python][Release] Add delvewheel for our Windows wheels #33981
Comments
It seems this is not the encouraged, see mentioned issue above. |
@raulcd I think this is unrelated to the discussion about whether or not including the C++ runtime dll. We still have plently of DLLs that we have to include in the wheels (i.e. to start, the various arrow libraries). And as far as I understand, delvewheel can be used to properly include those in the wheels (instead of doing that manually). |
oh! I misinterpreted the issue as it was only referencing |
…#35323) ### Rationale for this change We need to ship the C++ standard library with our Windows wheels, as it is not guaranteed that a recent enough version is present on the system. However, some other Python libraries may require an even more recent version than the one we ship. This may incur crashes when PyArrow is imported before such other Python library, as the older version of the C++ standard library would be used by both. ### What changes are included in this PR? Use a [fixed-up version](adang1345/delvewheel#59) of delvewheel that allows us to name-mangle an individual DLL, and name-mangle `msvcp140.dll` to ensure that other Python libraries do not reuse the version we ship. ### Are these changes tested? By regular wheel build tests. * Closes: #44855 * GitHub Issue: #33981 * GitHub Issue: #44855 Lead-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Describe the enhancement requested
For Python wheels on Linux/macOS we are using the corresponding auditwheel and delocate.
We should add delvewheel to our Windows wheels.
From the delvewheel GitHub Readme:
We are currently copying manually the following which should be taken care of with delvewheel:
https://github.com/apache/arrow/blob/master/ci/scripts/python_wheel_windows_build.bat#L122-L124
Component(s)
Python, Release
The text was updated successfully, but these errors were encountered: