test: migrate client module bookie tests to junit 5 #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlock-lin
changed the title
|
@shoothzj |
sherlock-lin
force-pushed
the
sherlock-upgrading-to-junit5-0511
branch
from
a22f04e to
ec09b5f
Compare
hezhangjian
reviewed
May 11, 2024
There was a problem hiding this comment.
Looks good, I have two advice:
- I think
migratemight be better thanUpgrade, WDYT? - As we have many tests, we should point on which part of tests are migrated in PR title. It's better to do like
Migrate All client tests to junit5, orMigrate xxxx module tests to junit5
sherlock-lin
changed the title
sherlock-lin
changed the title
sherlock-lin
changed the title
That's good advice, I'll make the adjustments！ |
hezhangjian
reviewed
May 12, 2024
| @@ -35,6 +37,7 @@ public BookieRecoveryUseIOThreadTest() { | |||
| super(1); | |||
| } | |||
|
|
|||
| @BeforeEach | |||
There was a problem hiding this comment.
I think we don't need this annotation, it's already on the base BookKeeperClusterTestCase
|
Thanks for your contribution, please fix the checkstyle violations. :) |
sherlock-lin
force-pushed
the
sherlock-upgrading-to-junit5-0511
branch
3 times, most recently
from
40a24e9 to
1289978
Compare
hezhangjian
approved these changes
May 15, 2024
sherlock-lin
force-pushed
the
sherlock-upgrading-to-junit5-0511
branch
from
1289978 to
44ce835
Compare
ok |
dlg99
approved these changes
May 16, 2024
hezhangjian
reviewed
May 16, 2024
| @@ -35,7 +35,8 @@ | |||
| import org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager; | |||
| import org.apache.bookkeeper.net.BookieId; | |||
| import org.apache.bookkeeper.test.BookKeeperClusterTestCase; | |||
| import org.junit.Test; | |||
| import org.junit.jupiter.api.Test; | |||
|
|
|||
There was a problem hiding this comment.
nit: unnecessary blank line
hezhangjian
reviewed
May 16, 2024
| @@ -20,8 +20,9 @@ | |||
| */ | |||
| package org.apache.bookkeeper.client; | |||
|
|
|||
| import static org.junit.Assert.assertEquals; | |||
| import static org.junit.Assert.fail; | |||
|
|
|||
There was a problem hiding this comment.
nit: unnecessary blank line
hezhangjian
reviewed
May 16, 2024
| @@ -61,6 +61,7 @@ public class BookieRecoveryTest extends BookKeeperClusterTestCase { | |||
|
|
|||
| // Object used for synchronizing async method calls | |||
| class SyncObject { | |||
|
|
|||
There was a problem hiding this comment.
nit: unnecessary blank line
hezhangjian
reviewed
May 16, 2024
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
There was a problem hiding this comment.
nit: unnecessary blank line
sherlock-lin
force-pushed
the
sherlock-upgrading-to-junit5-0511
branch
from
44ce835 to
aee1cd3
Compare
hezhangjian
changed the title
|
Thanks for your contribution, and welcome to the community. :) |
Glad to join the community. 😃 |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Fix #4322
Main Issue: #4322