Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust-version key in workspace Cargo.toml to inherit from workspace #9214

Closed
Jefffrey opened this issue Feb 13, 2024 · 0 comments · Fixed by #14009
Closed

Fix rust-version key in workspace Cargo.toml to inherit from workspace #9214

Jefffrey opened this issue Feb 13, 2024 · 0 comments · Fixed by #14009
Labels
enhancement New feature or request waiting-on-upstream PR is waiting on an upstream dependency to be updated

Comments

@Jefffrey
Copy link
Contributor

Is your feature request related to a problem or challenge?

Related to #8997

We were blocked from changing the keys to inherit from workspace due to foresterre/cargo-msrv#590

This should be now fixed with foresterre/cargo-msrv#882 being merged in, but we need to wait for the next release of cargo-msrv

Describe the solution you'd like

Change all occurrences in workspace Cargo.toml files to use the workspace specified rust-version instead of re-declaring

e.g. https://github.com/apache/arrow-datafusion/blob/2615d1bd81409b9ecc3e9a4683733c1d60992aa9/datafusion/core/Cargo.toml#L30-L33

Describe alternatives you've considered

No response

Additional context

This issue is mainly just a reminder for us (or someone) to do this in the future, whenever cargo-msrv has a new release (or we can use a 0.16 beta version)

@Jefffrey Jefffrey added enhancement New feature or request waiting-on-upstream PR is waiting on an upstream dependency to be updated labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting-on-upstream PR is waiting on an upstream dependency to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant