Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add hash calculations to calculation transform for various field types and algorithms #3372

Closed
vdwals opened this issue Nov 10, 2023 · 5 comments

Comments

@vdwals
Copy link
Contributor

vdwals commented Nov 10, 2023

What would you like to happen?

For some APIs I need to calculate hash values of certain strings for authentication. I utilized a external service called via REST API, but this had become a bottleneck and critical dependency quickly. Therefore I developed an own small plugin https://github.com/vdwals/hop-plugin-hashing based on the existing calculation transform.

During this process, I figured out, the current calculation transform could be enhanced to do certain hashing calculations with only a few changes, and therefore I would spent time more efficiently enhancing the calculation step than improving my plugin.

So sum up: Add further calculation to the calculation transform to calculate hash strings and binaries from certain inputs. Maybe even with a variable algorithm set by "Field B".

Issue Priority

Priority: 3

Issue Component

Component: Transforms

@hansva
Copy link
Contributor

hansva commented Nov 10, 2023

Extra calculations to the calculator are always welcome! Thanks for stepping up!
You can assign an issue to yourself by placing a .take-issue comment. (now i hope this won't trigger it and assign it to me)

@vdwals
Copy link
Contributor Author

vdwals commented Nov 10, 2023

.take-issue

@usbrandon
Copy link
Contributor

usbrandon commented Nov 10, 2023 via email

@mattcasters
Copy link
Contributor

Thanks Dennis!

@vdwals
Copy link
Contributor Author

vdwals commented Nov 22, 2023

Reading your use case, did you need something different than the "Add Checksum" Transform? I saw all the hash methods you used present there: [image: image.png]

On Fri, Nov 10, 2023 at 6:26 AM Dennis van der Wals < @.> wrote: .take-issue — Reply to this email directly, view it on GitHub <#3372 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJNF5QYNFGB5WI72KNAIMTYDYMPVAVCNFSM6AAAAAA7FZNJSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVGY2DONZXHA . You are receiving this because you are subscribed to this thread.Message ID: @.>

@usbrandon You're absolutely correct, and I appreciate you bringing it to my attention. I hadn't taken that into consideration. Thank you for letting me know. While it's still possible to calculate more values in a single step using the calculation plugin, it does seem quite unusual.

@vdwals vdwals closed this as completed Nov 22, 2023
@hansva hansva added this to the Not Applicable milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants