Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: hop-run.sh, passing parameters containing commas is broken #4765

Closed
pietrobaricco opened this issue Jan 7, 2025 · 3 comments
Closed

Comments

@pietrobaricco
Copy link

pietrobaricco commented Jan 7, 2025

Apache Hop version?

2.10

Java version?

1.17

Operating system

Linux

What happened?

Running pipelines with the recommended syntax for parameter values containing commas does not work.

/hop-run.sh --project="default" --environment="default" --runconfig="local" --file="/demo/files_download.hpl" --parameters=p1=abc,dossier_ids=\"25,352\"

in the pipeline, dossier_ids has value "25

This used to work in 2.9

Issue Priority

Priority: 3

Issue Component

Component: CLI, Component: Hop Run

@hansva
Copy link
Contributor

hansva commented Jan 7, 2025

confirmed, you can use the -ps setting to work around this. When using this setting it might be safer to split your parameters.

-p dossier_ids=1,3 -p p1=abc -ps=- setting ps will change the parameter split character so you could also write -p p1=abc-dossier_ids=25,352 you can also pick another character but be careful with characters that a terminal does not like.

@bamaer
Copy link
Contributor

bamaer commented Jan 7, 2025

colon (":") works for -ps if you pass multiple parameters, a lot of other characters are tricky, like Hans said.

@pietrobaricco
Copy link
Author

Thank you both, the workaround saved the day.
Consider adding it to the docs, as I douldn't find it there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants