Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: HTTP action - can't download files via HTTPS and Proxy #4768

Open
dave-csc opened this issue Jan 9, 2025 · 1 comment
Open

[Bug]: HTTP action - can't download files via HTTPS and Proxy #4768

dave-csc opened this issue Jan 9, 2025 · 1 comment

Comments

@dave-csc
Copy link
Contributor

dave-csc commented Jan 9, 2025

Apache Hop version?

2.11.0

Java version?

17.0.2

Operating system

Linux

What happened?

The HTTP action can download files via HTTPS only if a proxy is not specified (and not required): if a proxy server is specified, the values are ignored.

Proposed fix: set also the Java system variables https.proxyHost and https.proxyPort (in the current Hop version only the HTTP counterparts are set and reset), using the values provided in the dialog under Authentication.

Issue Priority

Priority: 2

Issue Component

Component: Actions

@dave-csc
Copy link
Contributor Author

dave-csc commented Jan 10, 2025

Found a (very partial and clumsy) workaround, if you need to execute a workflow via Hop Run: you can inject those Java variables by modifying the HOP_OPTIONS parameters, in a single-line (Linux) command this would be something like:

PREV_HOP_OPTIONS="${HOP_OPTIONS}" && HOP_OPTIONS="${HOP_OPTIONS} -Dhttps.proxyHost=my-proxy-host.com -Dhttps.proxyPort=3128" && hop-run.sh -e my_environment -f main.hwf && HOP_OPTIONS="${PREV_HOP_OPTIONS}"

For a better bug fix, you can probably consider to use the Java Proxy class instead of the system variables (more info here, section 3).

Hope this helps for the resolution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant