Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMN Editor: If the bottom of the overlay panel is close to editor bottom, it adds a vertical overflow after toggling an option #1679

Closed
ljmotta opened this issue Dec 9, 2024 · 3 comments · Fixed by apache/incubator-kie-tools#2845
Closed

DMN Editor: If the bottom of the overlay panel is close to editor bottom, it adds a vertical overflow after toggling an option #1679

ljmotta opened this issue Dec 9, 2024 · 3 comments · Fixed by apache/incubator-kie-tools#2845
Labels
area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects type:bug Something is behaving unexpectedly

Comments

@ljmotta
Copy link

ljmotta commented Dec 9, 2024 •
edited
Loading

In the DMN Editor, if the bottom of the overlay panel is close to the bottom of the DMN Editor, toggling an overlay option will add the vertical overflow to the panel.

To reproduce, it's possible to zoom in the browser:

bug-overlay.mp4
@ljmotta ljmotta added area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects labels Dec 9, 2024
@ljmotta ljmotta mentioned this issue Dec 9, 2024
Merged
@jomarko jomarko added the type:bug Something is behaving unexpectedly label Dec 10, 2024
@Kusuma04-dev Kusuma04-dev mentioned this issue Jan 10, 2025
Merged
@jomarko
Copy link

jomarko commented Jan 10, 2025

@ljmotta hi, during manual check of the PR I realized, I am not sure I understand what is the desired behavior:

  • we should never display vertical scrollbar
  • we should display vertical scrollbar only when part of the overlay panel is not visible (overlay panel being close to the screen border should not cause scrollbar to be visible)
  • ...

Thank you for clarification.

@ljmotta
Copy link
Author

ljmotta commented Jan 10, 2025

@jomarko I've updated the video to better show the bug.

@Kusuma04-dev
Copy link

closed by apache/incubator-kie-tools#2845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects type:bug Something is behaving unexpectedly
Projects
None yet
Milestone
No milestone
3 participants
@jomarko @ljmotta @Kusuma04-dev