From 18180541666200586ed297794a3151e924a9d134 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Tue, 20 Aug 2024 16:47:29 -0400 Subject: [PATCH] chore(tests): Spelling (#25454) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Evan Rusackas Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> --- tests/integration_tests/conftest.py | 2 +- tests/integration_tests/databases/api_tests.py | 10 +++++----- .../db_engine_specs/bigquery_tests.py | 4 ++-- .../integration_tests/db_engine_specs/gsheets_tests.py | 4 ++-- tests/integration_tests/db_engine_specs/mysql_tests.py | 4 ++-- .../db_engine_specs/postgres_tests.py | 10 +++++----- .../integration_tests/db_engine_specs/presto_tests.py | 2 +- tests/integration_tests/event_logger_tests.py | 2 +- tests/integration_tests/sql_lab/api_tests.py | 2 +- tests/unit_tests/db_engine_specs/test_athena.py | 4 ++-- tests/unit_tests/db_engine_specs/test_databricks.py | 8 ++++---- tests/unit_tests/db_engine_specs/test_mssql.py | 6 +++--- tests/unit_tests/pandas_postprocessing/test_pivot.py | 2 +- tests/unit_tests/pandas_postprocessing/test_rename.py | 2 +- tests/unit_tests/sql_parse_tests.py | 2 +- 15 files changed, 32 insertions(+), 32 deletions(-) diff --git a/tests/integration_tests/conftest.py b/tests/integration_tests/conftest.py index 537c1c882e0ce..8e8a5ca20cb41 100644 --- a/tests/integration_tests/conftest.py +++ b/tests/integration_tests/conftest.py @@ -79,7 +79,7 @@ def _create_user(username: str, role: str = "Admin", password: str = "general"): username, "firstname", "lastname", - "email@exaple.com", + "email@example.com", security_manager.find_role(role), password, ) diff --git a/tests/integration_tests/databases/api_tests.py b/tests/integration_tests/databases/api_tests.py index 677d6d36f9ae6..52a0db1affe79 100644 --- a/tests/integration_tests/databases/api_tests.py +++ b/tests/integration_tests/databases/api_tests.py @@ -2185,17 +2185,17 @@ def test_test_connection_failed_invalid_hostname( """ Database API: Test test connection failed due to invalid hostname """ - msg = 'psql: error: could not translate host name "locahost" to address: nodename nor servname provided, or not known' + msg = 'psql: error: could not translate host name "localhost_" to address: nodename nor servname provided, or not known' mock_build_db.return_value.set_sqlalchemy_uri.side_effect = DBAPIError( msg, None, None ) mock_build_db.return_value.db_engine_spec.__name__ = "Some name" superset_error = SupersetError( - message='Unable to resolve hostname "locahost".', + message='Unable to resolve hostname "localhost_".', error_type="CONNECTION_INVALID_HOSTNAME_ERROR", level="error", extra={ - "hostname": "locahost", + "hostname": "localhost_", "issue_codes": [ { "code": 1007, @@ -2212,7 +2212,7 @@ def test_test_connection_failed_invalid_hostname( self.login(ADMIN_USERNAME) data = { - "sqlalchemy_uri": "postgres://username:password@locahost:12345/db", + "sqlalchemy_uri": "postgres://username:password@localhost_:12345/db", "database_name": "examples", "impersonate_user": False, "server_cert": None, @@ -3840,7 +3840,7 @@ def test_validate_sql_errors(self): Database API: validate SQL with errors """ request_payload = { - "sql": "SELECT col1 froma table1", + "sql": "SELECT col1 from_ table1", "schema": None, "template_params": None, } diff --git a/tests/integration_tests/db_engine_specs/bigquery_tests.py b/tests/integration_tests/db_engine_specs/bigquery_tests.py index 53f9137076bb8..889c0295cfdac 100644 --- a/tests/integration_tests/db_engine_specs/bigquery_tests.py +++ b/tests/integration_tests/db_engine_specs/bigquery_tests.py @@ -336,11 +336,11 @@ def test_extract_errors(self): ) ] - msg = 'Syntax error: Expected end of input but got identifier "fromm"' + msg = 'Syntax error: Expected end of input but got identifier "from_"' result = BigQueryEngineSpec.extract_errors(Exception(msg)) assert result == [ SupersetError( - message='Please check your query for syntax errors at or near "fromm". Then, try running your query again.', + message='Please check your query for syntax errors at or near "from_". Then, try running your query again.', error_type=SupersetErrorType.SYNTAX_ERROR, level=ErrorLevel.ERROR, extra={ diff --git a/tests/integration_tests/db_engine_specs/gsheets_tests.py b/tests/integration_tests/db_engine_specs/gsheets_tests.py index fe34b7266753a..d66c54e2fce60 100644 --- a/tests/integration_tests/db_engine_specs/gsheets_tests.py +++ b/tests/integration_tests/db_engine_specs/gsheets_tests.py @@ -24,11 +24,11 @@ def test_extract_errors(self): """ Test that custom error messages are extracted correctly. """ - msg = 'SQLError: near "fromm": syntax error' + msg = 'SQLError: near "from_": syntax error' result = GSheetsEngineSpec.extract_errors(Exception(msg)) assert result == [ SupersetError( - message='Please check your query for syntax errors near "fromm". Then, try running your query again.', + message='Please check your query for syntax errors near "from_". Then, try running your query again.', error_type=SupersetErrorType.SYNTAX_ERROR, level=ErrorLevel.ERROR, extra={ diff --git a/tests/integration_tests/db_engine_specs/mysql_tests.py b/tests/integration_tests/db_engine_specs/mysql_tests.py index 36b41222b3cc5..5f32059484098 100644 --- a/tests/integration_tests/db_engine_specs/mysql_tests.py +++ b/tests/integration_tests/db_engine_specs/mysql_tests.py @@ -177,11 +177,11 @@ def test_extract_errors(self): ) ] - msg = "check the manual that corresponds to your MySQL server version for the right syntax to use near 'fromm" + msg = "check the manual that corresponds to your MySQL server version for the right syntax to use near 'from_" result = MySQLEngineSpec.extract_errors(Exception(msg)) assert result == [ SupersetError( - message='Please check your query for syntax errors near "fromm". Then, try running your query again.', + message='Please check your query for syntax errors near "from_". Then, try running your query again.', error_type=SupersetErrorType.SYNTAX_ERROR, level=ErrorLevel.ERROR, extra={ diff --git a/tests/integration_tests/db_engine_specs/postgres_tests.py b/tests/integration_tests/db_engine_specs/postgres_tests.py index 175ee65b2d0e2..4c4261ff57261 100644 --- a/tests/integration_tests/db_engine_specs/postgres_tests.py +++ b/tests/integration_tests/db_engine_specs/postgres_tests.py @@ -90,7 +90,7 @@ def test_time_exp_lowr_col_sec_1y(self): "(timestamp 'epoch' + lower_case * interval '1 second'))", ) - def test_time_exp_mixd_case_col_1y(self): + def test_time_exp_mixed_case_col_1y(self): """ DB Eng Specs (postgres): Test grain expr mixed case 1 YEAR """ @@ -241,14 +241,14 @@ def test_extract_errors(self): ] msg = ( - 'psql: error: could not translate host name "locahost" to address: ' + 'psql: error: could not translate host name "localhost_" to address: ' "nodename nor servname provided, or not known" ) result = PostgresEngineSpec.extract_errors(Exception(msg)) assert result == [ SupersetError( error_type=SupersetErrorType.CONNECTION_INVALID_HOSTNAME_ERROR, - message='The hostname "locahost" cannot be resolved.', + message='The hostname "localhost_" cannot be resolved.', level=ErrorLevel.ERROR, extra={ "engine_name": "PostgreSQL", @@ -421,11 +421,11 @@ def test_extract_errors(self): ) ] - msg = 'syntax error at or near "fromm"' + msg = 'syntax error at or near "from_"' result = PostgresEngineSpec.extract_errors(Exception(msg)) assert result == [ SupersetError( - message='Please check your query for syntax errors at or near "fromm". Then, try running your query again.', + message='Please check your query for syntax errors at or near "from_". Then, try running your query again.', error_type=SupersetErrorType.SYNTAX_ERROR, level=ErrorLevel.ERROR, extra={ diff --git a/tests/integration_tests/db_engine_specs/presto_tests.py b/tests/integration_tests/db_engine_specs/presto_tests.py index 69e5273f2ba95..b49405765a421 100644 --- a/tests/integration_tests/db_engine_specs/presto_tests.py +++ b/tests/integration_tests/db_engine_specs/presto_tests.py @@ -968,7 +968,7 @@ def test_extract_error_message_orig(self): result = PrestoEngineSpec._extract_error_message(exception) assert result == "name at location: msg" - def test_extract_error_message_db_errr(self): + def test_extract_error_message_db_error(self): from pyhive.exc import DatabaseError exception = DatabaseError({"message": "Err message"}) diff --git a/tests/integration_tests/event_logger_tests.py b/tests/integration_tests/event_logger_tests.py index d3cd2a4ff3fed..3f0acc30c00ed 100644 --- a/tests/integration_tests/event_logger_tests.py +++ b/tests/integration_tests/event_logger_tests.py @@ -53,7 +53,7 @@ def test_config_class_deprecation(self): # class is instantiated and returned self.assertIsInstance(res, DBEventLogger) - def test_raises_typerror_if_not_abc(self): + def test_raises_typeerror_if_not_abc(self): # test that assignment of non AbstractEventLogger derived type raises # TypeError with self.assertRaises(TypeError): diff --git a/tests/integration_tests/sql_lab/api_tests.py b/tests/integration_tests/sql_lab/api_tests.py index 282a0c993e261..e6c1f686b13c7 100644 --- a/tests/integration_tests/sql_lab/api_tests.py +++ b/tests/integration_tests/sql_lab/api_tests.py @@ -55,7 +55,7 @@ class TestSqlLabApi(SupersetTestCase): {"SQLLAB_BACKEND_PERSISTENCE": False}, clear=True, ) - def test_get_from_empty_bootsrap_data(self): + def test_get_from_empty_bootstrap_data(self): if utils.backend() == "postgresql": # failing return diff --git a/tests/unit_tests/db_engine_specs/test_athena.py b/tests/unit_tests/db_engine_specs/test_athena.py index 2e95576d90938..f954b3d04309d 100644 --- a/tests/unit_tests/db_engine_specs/test_athena.py +++ b/tests/unit_tests/db_engine_specs/test_athena.py @@ -55,11 +55,11 @@ def test_extract_errors() -> None: from superset.db_engine_specs.athena import AthenaEngineSpec - msg = ": mismatched input 'fromm'. Expecting: " + msg = ": mismatched input 'from_'. Expecting: " result = AthenaEngineSpec.extract_errors(Exception(msg)) assert result == [ SupersetError( - message='Please check your query for syntax errors at or near "fromm". Then, try running your query again.', + message='Please check your query for syntax errors at or near "from_". Then, try running your query again.', error_type=SupersetErrorType.SYNTAX_ERROR, level=ErrorLevel.ERROR, extra={ diff --git a/tests/unit_tests/db_engine_specs/test_databricks.py b/tests/unit_tests/db_engine_specs/test_databricks.py index 77d7313dc7532..652387471f49d 100644 --- a/tests/unit_tests/db_engine_specs/test_databricks.py +++ b/tests/unit_tests/db_engine_specs/test_databricks.py @@ -178,12 +178,12 @@ def test_extract_errors() -> None: Test that custom error messages are extracted correctly. """ - msg = ": mismatched input 'fromm'. Expecting: " + msg = ": mismatched input 'from_'. Expecting: " result = DatabricksNativeEngineSpec.extract_errors(Exception(msg)) assert result == [ SupersetError( - message=": mismatched input 'fromm'. Expecting: ", + message=": mismatched input 'from_'. Expecting: ", error_type=SupersetErrorType.GENERIC_DB_ENGINE_ERROR, level=ErrorLevel.ERROR, extra={ @@ -204,13 +204,13 @@ def test_extract_errors_with_context() -> None: Test that custom error messages are extracted correctly with context. """ - msg = ": mismatched input 'fromm'. Expecting: " + msg = ": mismatched input 'from_'. Expecting: " context = {"hostname": "foo"} result = DatabricksNativeEngineSpec.extract_errors(Exception(msg), context) assert result == [ SupersetError( - message=": mismatched input 'fromm'. Expecting: ", + message=": mismatched input 'from_'. Expecting: ", error_type=SupersetErrorType.GENERIC_DB_ENGINE_ERROR, level=ErrorLevel.ERROR, extra={ diff --git a/tests/unit_tests/db_engine_specs/test_mssql.py b/tests/unit_tests/db_engine_specs/test_mssql.py index 9a8cc36fcd5bc..38a5603e4ec93 100644 --- a/tests/unit_tests/db_engine_specs/test_mssql.py +++ b/tests/unit_tests/db_engine_specs/test_mssql.py @@ -94,7 +94,7 @@ def test_where_clause_n_prefix() -> None: assert query == query_expected -def test_time_exp_mixd_case_col_1y() -> None: +def test_time_exp_mixed_case_col_1y() -> None: from superset.db_engine_specs.mssql import MssqlEngineSpec col = column("MixedCase") @@ -291,14 +291,14 @@ def test_extract_errors() -> None: msg = dedent( """ DB-Lib error message 20009, severity 9: -Unable to connect: Adaptive Server is unavailable or does not exist (locahost) +Unable to connect: Adaptive Server is unavailable or does not exist (localhost_) """ ) result = MssqlEngineSpec.extract_errors(Exception(msg)) assert result == [ SupersetError( error_type=SupersetErrorType.CONNECTION_INVALID_HOSTNAME_ERROR, - message='The hostname "locahost" cannot be resolved.', + message='The hostname "localhost_" cannot be resolved.', level=ErrorLevel.ERROR, extra={ "engine_name": "Microsoft SQL Server", diff --git a/tests/unit_tests/pandas_postprocessing/test_pivot.py b/tests/unit_tests/pandas_postprocessing/test_pivot.py index 8efd203906077..5b05b9a3eab12 100644 --- a/tests/unit_tests/pandas_postprocessing/test_pivot.py +++ b/tests/unit_tests/pandas_postprocessing/test_pivot.py @@ -101,7 +101,7 @@ def test_pivot_fill_values(): def test_pivot_fill_column_values(): """ - Make sure pivot witn null column names returns correct DataFrame + Make sure pivot with null column names returns correct DataFrame """ df_copy = categories_df.copy() df_copy["category"] = None diff --git a/tests/unit_tests/pandas_postprocessing/test_rename.py b/tests/unit_tests/pandas_postprocessing/test_rename.py index f49680a352618..ee4e795e83e77 100644 --- a/tests/unit_tests/pandas_postprocessing/test_rename.py +++ b/tests/unit_tests/pandas_postprocessing/test_rename.py @@ -120,7 +120,7 @@ def test_should_raise_exception_duplication(): ) -def test_should_raise_exception_duplication_on_multiindx(): +def test_should_raise_exception_duplication_on_multiindex(): iterables = [["m1", "m2"], ["a", "b"], ["x", "y"]] columns = pd.MultiIndex.from_product(iterables, names=[None, "level1", "level2"]) df = pd.DataFrame(index=[0, 1, 2], columns=columns, data=1) diff --git a/tests/unit_tests/sql_parse_tests.py b/tests/unit_tests/sql_parse_tests.py index 6259d6272db6d..f6743f34bba3f 100644 --- a/tests/unit_tests/sql_parse_tests.py +++ b/tests/unit_tests/sql_parse_tests.py @@ -1551,7 +1551,7 @@ def get_rls_for_table( "id=42", "SELECT * FROM other_table WHERE 1=1", ), - # If there's no pre-existing WHERE clause we create one. + # If there's no preexisting WHERE clause we create one. ( "SELECT * FROM table", "table",