Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Handle scenario where release can be made from commit with failing checks #949

Open
Pijukatel opened this issue Jan 31, 2025 · 0 comments
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@Pijukatel
Copy link
Contributor

Pijukatel commented Jan 31, 2025

If tip of master contains commit with [skip ci] , then checks are not needed for release. In majority of cases [skip ci] commit follows 100% green checks commit, but in rare cases it can follow a commit that had some failed checks. Make sure that such commit can not be released.

For example see:
Image

@Pijukatel Pijukatel added debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team. labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

1 participant