From 7a8946b4f8c94648277636bd7114cb7570a1bdd9 Mon Sep 17 00:00:00 2001 From: Gerd Oberlechner Date: Mon, 4 Mar 2024 11:31:45 +0100 Subject: [PATCH] test for has_diff with None subnet Signed-off-by: Gerd Oberlechner --- reconcile/test/test_ocm_machine_pools.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/reconcile/test/test_ocm_machine_pools.py b/reconcile/test/test_ocm_machine_pools.py index 2a873e9ad1..2a6ecf0497 100644 --- a/reconcile/test/test_ocm_machine_pools.py +++ b/reconcile/test/test_ocm_machine_pools.py @@ -345,6 +345,13 @@ def test_pool_node_pool_invalid_diff_subnet(node_pool, cluster_machine_pool): assert node_pool.invalid_diff(cluster_machine_pool) +def test_pool_node_pool_valid_diff_subnet(node_pool, cluster_machine_pool): + cluster_machine_pool.subnet = None + node_pool.subnet = "foo" + cluster_machine_pool.replicas = 2 + assert not node_pool.has_diff(cluster_machine_pool) + + def test_pool_node_pool_invalid_diff_instance_type(node_pool, cluster_machine_pool): cluster_machine_pool.instance_type = "foo" assert node_pool.invalid_diff(cluster_machine_pool) @@ -1114,7 +1121,7 @@ def test_update_app_interface_with_subnet( mocker: MockerFixture, hypershift_cluster: ClusterV1, ) -> None: - hypershift_cluster.machine_pools[0].subnet = None + hypershift_cluster.machine_pools[0].subnet = None # type: ignore setup_mocks( mocker, clusters=[hypershift_cluster],