From 94527d663f80ffafcc5f974257222d3779d448ee Mon Sep 17 00:00:00 2001
From: Scott Mitchell <scott_mitchell@apple.com>
Date: Fri, 21 Apr 2023 13:15:46 -0700
Subject: [PATCH 1/3] DefaultDnsClient reduce log level for TTL > max

Motivation:
DefaultDnsClient logs at info level if the TTL from DNS
is larger than the maximum configured TTL value. This
level of logging can be noisy in production and not
necessarily be within the client's control.
---
 .../servicetalk/dns/discovery/netty/DefaultDnsClient.java | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java b/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
index 64aafef60f..f2d85ba62b 100644
--- a/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
+++ b/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
@@ -813,9 +813,11 @@ private void handleResolveDone0(final Future<DnsAnswer<T>> addressFuture,
                     final List<T> addresses = dnsAnswer.answer();
                     ttlNanos = dnsAnswer.ttlNanos();
                     if (ttlNanos > maxTTLNanos) {
-                        LOGGER.info("{} result for {} has a high TTL={}s which is larger than configured maxTTL={}s.",
-                                DefaultDnsClient.this, AbstractDnsPublisher.this,
-                                NANOSECONDS.toSeconds(ttlNanos), NANOSECONDS.toSeconds(maxTTLNanos));
+                        if (LOGGER.isDebugEnabled()) {
+                            LOGGER.debug("{} result for {} has a high TTL={}s which is larger than configured maxTTL={}s.",
+                                    DefaultDnsClient.this, AbstractDnsPublisher.this,
+                                    NANOSECONDS.toSeconds(ttlNanos), NANOSECONDS.toSeconds(maxTTLNanos));
+                        }
                         ttlNanos = maxTTLNanos;
                     }
                     final List<ServiceDiscovererEvent<T>> events = calculateDifference(activeAddresses, addresses,

From af5bb5bedbbdc5180e32e38c01fb96d37689b59d Mon Sep 17 00:00:00 2001
From: Scott Mitchell <scott_mitchell@apple.com>
Date: Fri, 21 Apr 2023 13:25:10 -0700
Subject: [PATCH 2/3] simplify log

---
 .../servicetalk/dns/discovery/netty/DefaultDnsClient.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java b/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
index f2d85ba62b..94817b5638 100644
--- a/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
+++ b/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
@@ -814,9 +814,9 @@ private void handleResolveDone0(final Future<DnsAnswer<T>> addressFuture,
                     ttlNanos = dnsAnswer.ttlNanos();
                     if (ttlNanos > maxTTLNanos) {
                         if (LOGGER.isDebugEnabled()) {
-                            LOGGER.debug("{} result for {} has a high TTL={}s which is larger than configured maxTTL={}s.",
-                                    DefaultDnsClient.this, AbstractDnsPublisher.this,
-                                    NANOSECONDS.toSeconds(ttlNanos), NANOSECONDS.toSeconds(maxTTLNanos));
+                            LOGGER.debug("{} result for {} has TTL={}s > maxTTL={}s",
+                                    DefaultDnsClient.this, AbstractDnsPublisher.this, NANOSECONDS.toSeconds(ttlNanos),
+                                    NANOSECONDS.toSeconds(maxTTLNanos));
                         }
                         ttlNanos = maxTTLNanos;
                     }

From f9e42cc22b9a77dffc752f97ac5f4c7524f276d7 Mon Sep 17 00:00:00 2001
From: Scott Mitchell <scott_mitchell@apple.com>
Date: Fri, 21 Apr 2023 13:28:56 -0700
Subject: [PATCH 3/3] remove unit

---
 .../io/servicetalk/dns/discovery/netty/DefaultDnsClient.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java b/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
index 94817b5638..6c69c0db69 100644
--- a/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
+++ b/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DefaultDnsClient.java
@@ -814,7 +814,7 @@ private void handleResolveDone0(final Future<DnsAnswer<T>> addressFuture,
                     ttlNanos = dnsAnswer.ttlNanos();
                     if (ttlNanos > maxTTLNanos) {
                         if (LOGGER.isDebugEnabled()) {
-                            LOGGER.debug("{} result for {} has TTL={}s > maxTTL={}s",
+                            LOGGER.debug("{} result for {} has TTL={} > maxTTL={}",
                                     DefaultDnsClient.this, AbstractDnsPublisher.this, NANOSECONDS.toSeconds(ttlNanos),
                                     NANOSECONDS.toSeconds(maxTTLNanos));
                         }