General CSV reader #152
Closed
General CSV reader #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Syntax checkNo syntax error, good job! 💜 |
|
Coverage after merging csv_reader into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
reverendbedford
requested changes
Jun 24, 2024
|
I just merged #151 so I'll have to rebase this one.
Mechanistically yes. Though right now I rely on the glob pattern |
reverendbedford
approved these changes
Jun 27, 2024
|
I think this has been abandoned? |
|
We can revive this if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a header-only CSV reader from https://github.com/vincentlaucsb/csv-parser. I didn't include the library as a cmake subdirectory because it's folder hierarchy makes install very difficult. Since it is MIT license, I just copied the single header file into our contrib folder.
The primary entry point for CSV reader is
Sequence. It is designed as a sequence reader to retrieve a single column from a CSV file. Design details are included in the class docstring. It's zero-effort for developers to opt-in to use a CSV to fill a vector by changingoptions.set<std::vector<Real>>("foo");to
options.set<Sequence<Real>>("foo");With the above code, users are able to specify the sequence in one of three ways:
foo = '1 2 3 4 5 6'<-- equivalent to parsingstd::vector<Real>foo = 'my.csv:key'<-- we try to readmy.csvand fill the vector with the CSV column with namekey.foo = 'my.csv:[2]'<-- we try to readmy.csvand fill the vector with the CSV column with index2.Other changes are just for expanding parser support and test coverage.
This is the (big) first step towards @sapitts 's request of defining irradiation eigenstrain using a CSV file.
close #154