Some logs don't respect the --log-format=json flag

[lucasfcnunes]

Pre-requisites

• I have double-checked my configuration
• I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
• I have searched existing issues and could not find a match for this bug
• I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

All logs should be formatted as json when you set --log-format=json, none plain (gofmt log)

Version(s)

v3.6.2

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflow that uses private images.

- Set `--log-format=json`
- Restart the controller
- Watch some non-json logs being logged

Logs from the workflow controller

{...}
time="2025-01-16T15:57:46Z" level=info msg="Memoization caches will be garbage-collected if they have not been hit after" gcAfterNotHitDuration=30s
time="2025-01-16T15:57:46Z" level=info msg="cron config" cronSyncPeriod=10s
time="2025-01-16T15:57:46Z" level=info msg="index config" indexWorkflowSemaphoreKeys=true
{...}

Logs from in your workflow's wait container

N/A

[isubasinghe]

This will be handled in the logging refactor that I am working on currently.