Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove refresh_extension_manager #1881

Open
braingram opened this issue Dec 19, 2024 · 0 comments
Open

Remove refresh_extension_manager #1881

braingram opened this issue Dec 19, 2024 · 0 comments

Comments

@braingram
Copy link
Contributor

Description of the problem

AsdfFile.schema_info and AsdfFile.info have an argument refresh_extension_manager. This ultimately triggers:

asdf/asdf/_node_info.py

Lines 108 to 117 in dd84c66

def _get_extension_manager(refresh_extension_manager):
from ._asdf import AsdfFile, get_config
from .extension import ExtensionManager
af = AsdfFile()
if refresh_extension_manager:
config = get_config()
af._extension_manager = ExtensionManager(config.extensions)
return af.extension_manager

Which loads a fresh default "extension_manager" using default extensions.

This option is entirely unused by downstream and could be deprecated (or perhaps just removed). I am also not sure it needs to be used internally (a quick test at removing it resulted in no test failures).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant