Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when using RenderConfig(dbt_deps=True) and operator_args={"install_deps": False} #1457

Open
tatiana opened this issue Jan 13, 2025 · 1 comment
Open

Bug when using RenderConfig(dbt_deps=True) and operator_args={"install_deps": False} #1457

tatiana opened this issue Jan 13, 2025 · 1 comment
Assignees
@tatiana
Labels
area:rendering Related to rendering, like Jinja, Airflow tasks, etc bug Something isn't working customer request An Astronomer customer made requested this stretch goal
Milestone
Cosmos 1.9.0

Comments

@tatiana
Copy link
Collaborator

tatiana commented Jan 13, 2025 •
edited
Loading

Customer is facing this error when RenderConfig(dbt_deps=True) and operator_args={"install_deps": False}:
Image

This issue does not happen if both of them are False.
@tatiana tatiana added bug Something isn't working customer request An Astronomer customer made requested this labels Jan 13, 2025
@tatiana tatiana changed the title Bug when using RenderConfig(install_deps=True) and operator_args={"install_deps"=False} Bug when using RenderConfig(install_deps=True) and operator_args={"install_deps": False} Jan 13, 2025
@dosubot dosubot bot added the area:rendering Related to rendering, like Jinja, Airflow tasks, etc label Jan 13, 2025
@tatiana tatiana mentioned this issue Jan 13, 2025
Open
@tatiana tatiana added this to the Cosmos 1.9.0 milestone Jan 13, 2025
@tatiana tatiana self-assigned this Jan 20, 2025
@pankajkoti pankajkoti changed the title Bug when using RenderConfig(install_deps=True) and operator_args={"install_deps": False} Bug when using RenderConfig(dbt_deps=True) and operator_args={"install_deps": False} Jan 29, 2025
@tatiana
Copy link
Collaborator Author

tatiana commented Jan 29, 2025 •
edited
Loading

I've aligned with @pankajkoti and @pankajastro, and we agreed on the following:

  • We should raise a user-friendly message when the values of operator args and render config differ (if LoadMode.DBT_LS)
  • We should introduce a new configuration in ProjectConfig (default True) that would centralise this control since, ideally ,the values should not defer - and we can add deprecation warnings for the other two
  • Log a ticket for Cosmos 2.0 to deprecate "old" parameters
  • We should confirm that users are still able to install deps in specific operators/tasks only
  • Make sure we have ticket related to documenting performance tuning tips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tatiana tatiana

Labels
area:rendering Related to rendering, like Jinja, Airflow tasks, etc bug Something isn't working customer request An Astronomer customer made requested this stretch goal
Projects
None yet
Milestone
Cosmos 1.9.0
Development

No branches or pull requests
1 participant
@tatiana